Commit d932cd49 authored by Linus Walleij's avatar Linus Walleij

gpio: free handles in fringe cases

If we fail when copying the ioctl() struct to userspace we still
need to clean up the cruft otherwise left behind or it will stay
around until the issuing process terminates the file handle.
Reported-by: default avatarAlexander Stein <>
Acked-by: default avatarAlexander Stein <>
Signed-off-by: Linus Walleij's avatarLinus Walleij <>
parent a944a892
......@@ -488,8 +488,10 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
handlereq.fd = fd;
if (copy_to_user(ip, &handlereq, sizeof(handlereq)))
return -EFAULT;
if (copy_to_user(ip, &handlereq, sizeof(handlereq))) {
ret = -EFAULT;
goto out_free_descs;
dev_dbg(&gdev->dev, "registered chardev handle for %d lines\n",
......@@ -784,8 +786,10 @@ static int lineevent_create(struct gpio_device *gdev, void __user *ip)
eventreq.fd = fd;
if (copy_to_user(ip, &eventreq, sizeof(eventreq)))
return -EFAULT;
if (copy_to_user(ip, &eventreq, sizeof(eventreq))) {
ret = -EFAULT;
goto out_free_irq;
return 0;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment