Commit d7b236e1 authored by Michal Hocko's avatar Michal Hocko Committed by Linus Torvalds

mm: drop migrate type checks from has_unmovable_pages

Michael has noticed that the memory offline tries to migrate kernel code
pages when doing

 echo 0 > /sys/devices/system/memory/memory0/online

The current implementation will fail the operation after several failed
page migration attempts but we shouldn't even attempt to migrate that
memory and fail right away because this memory is clearly not
migrateable.  This will become a real problem when we drop the retry
loop counter resp.  timeout.

The real problem is in has_unmovable_pages in fact.  We should fail if
there are any non migrateable pages in the area.  In orther to guarantee
that remove the migrate type checks because MIGRATE_MOVABLE is not
guaranteed to contain only migrateable pages.  It is merely a heuristic.
Similarly MIGRATE_CMA does guarantee that the page allocator doesn't
allocate any non-migrateable pages from the block but CMA allocations
themselves are unlikely to migrateable.  Therefore remove both checks.

[ remove unused local `mt']
Link: default avatarMichal Hocko <>
Reported-by: default avatarMichael Ellerman <>
Tested-by: default avatarMichael Ellerman <>
Acked-by: default avatarVlastimil Babka <>
Tested-by: Tony Lindgren's avatarTony Lindgren <>
Tested-by: default avatarRan Wang <>
Cc: Igor Mammedov <>
Cc: KAMEZAWA Hiroyuki <>
Cc: Reza Arbab <>
Cc: Vitaly Kuznetsov <>
Cc: Xishi Qiu <>
Cc: Yasuaki Ishimatsu <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 4c578dce
......@@ -7356,7 +7356,6 @@ bool has_unmovable_pages(struct zone *zone, struct page *page, int count,
bool skip_hwpoisoned_pages)
unsigned long pfn, iter, found;
int mt;
* For avoiding noise data, lru_add_drain_all() should be called
......@@ -7364,9 +7363,6 @@ bool has_unmovable_pages(struct zone *zone, struct page *page, int count,
if (zone_idx(zone) == ZONE_MOVABLE)
return false;
mt = get_pageblock_migratetype(page);
if (mt == MIGRATE_MOVABLE || is_migrate_cma(mt))
return false;
pfn = page_to_pfn(page);
for (found = 0, iter = 0; iter < pageblock_nr_pages; iter++) {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment