Commit bdf64381 authored by Julia Lawall's avatar Julia Lawall Committed by Roland Dreier
Browse files

RDMA/nes: Remove duplicate .ndo_set_mac_address field initialization

The definition of nes_netdev_ops has initializations of a local function
and eth_mac_addr for its ndo_set_mac_address field.  This change uses only
the local function.

The semantic match that finds this problem is as follows:

// <smpl>

identifier I, s, fld;
position p0,p;
expression E;

struct I s =@p0 { ... .fld@p = E, ...};

identifier I, s, r.fld;
position r.p0,p;
expression E;

struct I s =@p0 { ... .fld@p = E, ...};

p0 << r.p0;
fld << r.fld;
ps << s.p;
pr << r.p;

if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column):
// </smpl>
Signed-off-by: default avatarJulia Lawall <>
Signed-off-by: default avatarRoland Dreier <>
parent 86d71014
......@@ -1566,7 +1566,6 @@ static const struct net_device_ops nes_netdev_ops = {
.ndo_set_mac_address = nes_netdev_set_mac_address,
.ndo_set_multicast_list = nes_netdev_set_multicast_list,
.ndo_change_mtu = nes_netdev_change_mtu,
.ndo_set_mac_address = eth_mac_addr,
.ndo_validate_addr = eth_validate_addr,
.ndo_vlan_rx_register = nes_netdev_vlan_rx_register,
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment