Commit a99d76f9 authored by Jingoo Han's avatar Jingoo Han Committed by Bryan Wu

leds: leds-gpio: use gpio_request_one

Using gpio_request_one can make the code simpler because it can
set the direction and initial value in one shot.
Signed-off-by: default avatarJingoo Han <>
Signed-off-by: default avatarBryan Wu <>
parent 14ce82e5
......@@ -106,10 +106,6 @@ static int __devinit create_gpio_led(const struct gpio_led *template,
return 0;
ret = gpio_request(template->gpio, template->name);
if (ret < 0)
return ret;
led_dat-> = template->name;
led_dat->cdev.default_trigger = template->default_trigger;
led_dat->gpio = template->gpio;
......@@ -129,10 +125,12 @@ static int __devinit create_gpio_led(const struct gpio_led *template,
if (!template->retain_state_suspended)
led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME;
ret = gpio_direction_output(led_dat->gpio, led_dat->active_low ^ state);
ret = gpio_request_one(template->gpio,
GPIOF_DIR_OUT | (led_dat->active_low ^ state),
if (ret < 0)
goto err;
return ret;
INIT_WORK(&led_dat->work, gpio_led_work);
ret = led_classdev_register(parent, &led_dat->cdev);
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment