Commit 88e24c3a authored by Yong Zhang's avatar Yong Zhang Committed by Takashi Iwai
Browse files

sound: irq: Remove IRQF_DISABLED

Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a

:
genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.
Signed-off-by: default avatarYong Zhang <yong.zhang0@gmail.com>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Takashi Iwai's avatarTakashi Iwai <tiwai@suse.de>
parent af1910a8
...@@ -62,7 +62,7 @@ static int snd_legacy_find_free_irq(int *irq_table) ...@@ -62,7 +62,7 @@ static int snd_legacy_find_free_irq(int *irq_table)
{ {
while (*irq_table != -1) { while (*irq_table != -1) {
if (!request_irq(*irq_table, snd_legacy_empty_irq_handler, if (!request_irq(*irq_table, snd_legacy_empty_irq_handler,
IRQF_DISABLED | IRQF_PROBE_SHARED, "ALSA Test IRQ", IRQF_PROBE_SHARED, "ALSA Test IRQ",
(void *) irq_table)) { (void *) irq_table)) {
free_irq(*irq_table, (void *) irq_table); free_irq(*irq_table, (void *) irq_table);
return *irq_table; return *irq_table;
......
...@@ -443,7 +443,7 @@ static int aaci_pcm_open(struct snd_pcm_substream *substream) ...@@ -443,7 +443,7 @@ static int aaci_pcm_open(struct snd_pcm_substream *substream)
mutex_lock(&aaci->irq_lock); mutex_lock(&aaci->irq_lock);
if (!aaci->users++) { if (!aaci->users++) {
ret = request_irq(aaci->dev->irq[0], aaci_irq, ret = request_irq(aaci->dev->irq[0], aaci_irq,
IRQF_SHARED | IRQF_DISABLED, DRIVER_NAME, aaci); IRQF_SHARED, DRIVER_NAME, aaci);
if (ret != 0) if (ret != 0)
aaci->users--; aaci->users--;
} }
......
...@@ -359,7 +359,7 @@ int __devinit pxa2xx_ac97_hw_probe(struct platform_device *dev) ...@@ -359,7 +359,7 @@ int __devinit pxa2xx_ac97_hw_probe(struct platform_device *dev)
if (ret) if (ret)
goto err_clk2; goto err_clk2;
ret = request_irq(IRQ_AC97, pxa2xx_ac97_irq, IRQF_DISABLED, "AC97", NULL); ret = request_irq(IRQ_AC97, pxa2xx_ac97_irq, 0, "AC97", NULL);
if (ret < 0) if (ret < 0)
goto err_irq; goto err_irq;
......
...@@ -1153,7 +1153,7 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct platform_device *pfdev, ...@@ -1153,7 +1153,7 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct platform_device *pfdev,
"0x%x done\n", (unsigned int)ml403_ac97cr->port); "0x%x done\n", (unsigned int)ml403_ac97cr->port);
/* get irq */ /* get irq */
irq = platform_get_irq(pfdev, 0); irq = platform_get_irq(pfdev, 0);
if (request_irq(irq, snd_ml403_ac97cr_irq, IRQF_DISABLED, if (request_irq(irq, snd_ml403_ac97cr_irq, 0,
dev_name(&pfdev->dev), (void *)ml403_ac97cr)) { dev_name(&pfdev->dev), (void *)ml403_ac97cr)) {
snd_printk(KERN_ERR SND_ML403_AC97CR_DRIVER ": " snd_printk(KERN_ERR SND_ML403_AC97CR_DRIVER ": "
"unable to grab IRQ %d\n", "unable to grab IRQ %d\n",
...@@ -1166,7 +1166,7 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct platform_device *pfdev, ...@@ -1166,7 +1166,7 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct platform_device *pfdev,
"request (playback) irq %d done\n", "request (playback) irq %d done\n",
ml403_ac97cr->irq); ml403_ac97cr->irq);
irq = platform_get_irq(pfdev, 1); irq = platform_get_irq(pfdev, 1);
if (request_irq(irq, snd_ml403_ac97cr_irq, IRQF_DISABLED, if (request_irq(irq, snd_ml403_ac97cr_irq, 0,
dev_name(&pfdev->dev), (void *)ml403_ac97cr)) { dev_name(&pfdev->dev), (void *)ml403_ac97cr)) {
snd_printk(KERN_ERR SND_ML403_AC97CR_DRIVER ": " snd_printk(KERN_ERR SND_ML403_AC97CR_DRIVER ": "
"unable to grab IRQ %d\n", "unable to grab IRQ %d\n",
......
...@@ -577,7 +577,7 @@ int snd_mpu401_uart_new(struct snd_card *card, int device, ...@@ -577,7 +577,7 @@ int snd_mpu401_uart_new(struct snd_card *card, int device,
else else
mpu->cport = port + 1; mpu->cport = port + 1;
if (irq >= 0) { if (irq >= 0) {
if (request_irq(irq, snd_mpu401_uart_interrupt, IRQF_DISABLED, if (request_irq(irq, snd_mpu401_uart_interrupt, 0,
"MPU401 UART", (void *) mpu)) { "MPU401 UART", (void *) mpu)) {
snd_printk(KERN_ERR "mpu401_uart: " snd_printk(KERN_ERR "mpu401_uart: "
"unable to grab IRQ %d\n", irq); "unable to grab IRQ %d\n", irq);
......
...@@ -589,7 +589,7 @@ static int __devinit snd_mtpav_get_ISA(struct mtpav * mcard) ...@@ -589,7 +589,7 @@ static int __devinit snd_mtpav_get_ISA(struct mtpav * mcard)
return -EBUSY; return -EBUSY;
} }
mcard->port = port; mcard->port = port;
if (request_irq(irq, snd_mtpav_irqh, IRQF_DISABLED, "MOTU MTPAV", mcard)) { if (request_irq(irq, snd_mtpav_irqh, 0, "MOTU MTPAV", mcard)) {
snd_printk(KERN_ERR "MTVAP IRQ %d busy\n", irq); snd_printk(KERN_ERR "MTVAP IRQ %d busy\n", irq);
return -EBUSY; return -EBUSY;
} }
......
...@@ -816,7 +816,7 @@ static int __devinit snd_uart16550_create(struct snd_card *card, ...@@ -816,7 +816,7 @@ static int __devinit snd_uart16550_create(struct snd_card *card,
if (irq >= 0 && irq != SNDRV_AUTO_IRQ) { if (irq >= 0 && irq != SNDRV_AUTO_IRQ) {
if (request_irq(irq, snd_uart16550_interrupt, if (request_irq(irq, snd_uart16550_interrupt,
IRQF_DISABLED, "Serial MIDI", uart)) { 0, "Serial MIDI", uart)) {
snd_printk(KERN_WARNING snd_printk(KERN_WARNING
"irq %d busy. Using Polling.\n", irq); "irq %d busy. Using Polling.\n", irq);
} else { } else {
......
...@@ -595,7 +595,7 @@ int __devinit snd_ad1816a_create(struct snd_card *card, ...@@ -595,7 +595,7 @@ int __devinit snd_ad1816a_create(struct snd_card *card,
snd_ad1816a_free(chip); snd_ad1816a_free(chip);
return -EBUSY; return -EBUSY;
} }
if (request_irq(irq, snd_ad1816a_interrupt, IRQF_DISABLED, "AD1816A", (void *) chip)) { if (request_irq(irq, snd_ad1816a_interrupt, 0, "AD1816A", (void *) chip)) {
snd_printk(KERN_ERR "ad1816a: can't grab IRQ %d\n", irq); snd_printk(KERN_ERR "ad1816a: can't grab IRQ %d\n", irq);
snd_ad1816a_free(chip); snd_ad1816a_free(chip);
return -EBUSY; return -EBUSY;
......
...@@ -661,7 +661,7 @@ int snd_es1688_create(struct snd_card *card, ...@@ -661,7 +661,7 @@ int snd_es1688_create(struct snd_card *card,
snd_printk(KERN_ERR "es1688: can't grab port 0x%lx\n", port + 4); snd_printk(KERN_ERR "es1688: can't grab port 0x%lx\n", port + 4);
return -EBUSY; return -EBUSY;
} }
if (request_irq(irq, snd_es1688_interrupt, IRQF_DISABLED, "ES1688", (void *) chip)) { if (request_irq(irq, snd_es1688_interrupt, 0, "ES1688", (void *) chip)) {
snd_printk(KERN_ERR "es1688: can't grab IRQ %d\n", irq); snd_printk(KERN_ERR "es1688: can't grab IRQ %d\n", irq);
return -EBUSY; return -EBUSY;
} }
......
...@@ -1805,7 +1805,7 @@ static int __devinit snd_es18xx_new_device(struct snd_card *card, ...@@ -1805,7 +1805,7 @@ static int __devinit snd_es18xx_new_device(struct snd_card *card,
return -EBUSY; return -EBUSY;
} }
if (request_irq(irq, snd_es18xx_interrupt, IRQF_DISABLED, "ES18xx", if (request_irq(irq, snd_es18xx_interrupt, 0, "ES18xx",
(void *) card)) { (void *) card)) {
snd_es18xx_free(card); snd_es18xx_free(card);
snd_printk(KERN_ERR PFX "unable to grap IRQ %d\n", irq); snd_printk(KERN_ERR PFX "unable to grap IRQ %d\n", irq);
......
...@@ -180,7 +180,7 @@ int snd_gus_create(struct snd_card *card, ...@@ -180,7 +180,7 @@ int snd_gus_create(struct snd_card *card,
snd_gus_free(gus); snd_gus_free(gus);
return -EBUSY; return -EBUSY;
} }
if (irq >= 0 && request_irq(irq, snd_gus_interrupt, IRQF_DISABLED, "GUS GF1", (void *) gus)) { if (irq >= 0 && request_irq(irq, snd_gus_interrupt, 0, "GUS GF1", (void *) gus)) {
snd_printk(KERN_ERR "gus: can't grab irq %d\n", irq); snd_printk(KERN_ERR "gus: can't grab irq %d\n", irq);
snd_gus_free(gus); snd_gus_free(gus);
return -EBUSY; return -EBUSY;
......
...@@ -291,7 +291,7 @@ static int __devinit snd_gusmax_probe(struct device *pdev, unsigned int dev) ...@@ -291,7 +291,7 @@ static int __devinit snd_gusmax_probe(struct device *pdev, unsigned int dev)
goto _err; goto _err;
} }
if (request_irq(xirq, snd_gusmax_interrupt, IRQF_DISABLED, "GUS MAX", (void *)maxcard)) { if (request_irq(xirq, snd_gusmax_interrupt, 0, "GUS MAX", (void *)maxcard)) {
snd_printk(KERN_ERR PFX "unable to grab IRQ %d\n", xirq); snd_printk(KERN_ERR PFX "unable to grab IRQ %d\n", xirq);
err = -EBUSY; err = -EBUSY;
goto _err; goto _err;
......
...@@ -684,7 +684,7 @@ static int __devinit snd_interwave_probe(struct snd_card *card, int dev) ...@@ -684,7 +684,7 @@ static int __devinit snd_interwave_probe(struct snd_card *card, int dev)
if ((err = snd_gus_initialize(gus)) < 0) if ((err = snd_gus_initialize(gus)) < 0)
return err; return err;
if (request_irq(xirq, snd_interwave_interrupt, IRQF_DISABLED, if (request_irq(xirq, snd_interwave_interrupt, 0,
"InterWave", iwcard)) { "InterWave", iwcard)) {
snd_printk(KERN_ERR PFX "unable to grab IRQ %d\n", xirq); snd_printk(KERN_ERR PFX "unable to grab IRQ %d\n", xirq);
return -EBUSY; return -EBUSY;
......
...@@ -667,7 +667,7 @@ static int __devinit snd_opl3sa2_probe(struct snd_card *card, int dev) ...@@ -667,7 +667,7 @@ static int __devinit snd_opl3sa2_probe(struct snd_card *card, int dev)
err = snd_opl3sa2_detect(card); err = snd_opl3sa2_detect(card);
if (err < 0) if (err < 0)
return err; return err;
err = request_irq(xirq, snd_opl3sa2_interrupt, IRQF_DISABLED, err = request_irq(xirq, snd_opl3sa2_interrupt, 0,
"OPL3-SA2", card); "OPL3-SA2", card);
if (err) { if (err) {
snd_printk(KERN_ERR PFX "can't grab IRQ %d\n", xirq); snd_printk(KERN_ERR PFX "can't grab IRQ %d\n", xirq);
......
...@@ -892,7 +892,7 @@ static int __devinit snd_opti9xx_probe(struct snd_card *card) ...@@ -892,7 +892,7 @@ static int __devinit snd_opti9xx_probe(struct snd_card *card)
#endif #endif
#ifdef OPTi93X #ifdef OPTi93X
error = request_irq(irq, snd_opti93x_interrupt, error = request_irq(irq, snd_opti93x_interrupt,
IRQF_DISABLED, DEV_NAME" - WSS", chip); 0, DEV_NAME" - WSS", chip);
if (error < 0) { if (error < 0) {
snd_printk(KERN_ERR "opti9xx: can't grab IRQ %d\n", irq); snd_printk(KERN_ERR "opti9xx: can't grab IRQ %d\n", irq);
return error; return error;
......
...@@ -240,7 +240,7 @@ int snd_sbdsp_create(struct snd_card *card, ...@@ -240,7 +240,7 @@ int snd_sbdsp_create(struct snd_card *card,
if (request_irq(irq, irq_handler, if (request_irq(irq, irq_handler,
(hardware == SB_HW_ALS4000 || (hardware == SB_HW_ALS4000 ||
hardware == SB_HW_CS5530) ? hardware == SB_HW_CS5530) ?
IRQF_SHARED : IRQF_DISABLED, IRQF_SHARED : 0,
"SoundBlaster", (void *) chip)) { "SoundBlaster", (void *) chip)) {
snd_printk(KERN_ERR "sb: can't grab irq %d\n", irq); snd_printk(KERN_ERR "sb: can't grab irq %d\n", irq);
snd_sbdsp_free(chip); snd_sbdsp_free(chip);
......
...@@ -418,7 +418,7 @@ snd_wavefront_probe (struct snd_card *card, int dev) ...@@ -418,7 +418,7 @@ snd_wavefront_probe (struct snd_card *card, int dev)
return -EBUSY; return -EBUSY;
} }
if (request_irq(ics2115_irq[dev], snd_wavefront_ics2115_interrupt, if (request_irq(ics2115_irq[dev], snd_wavefront_ics2115_interrupt,
IRQF_DISABLED, "ICS2115", acard)) { 0, "ICS2115", acard)) {
snd_printk(KERN_ERR "unable to use ICS2115 IRQ %d\n", ics2115_irq[dev]); snd_printk(KERN_ERR "unable to use ICS2115 IRQ %d\n", ics2115_irq[dev]);
return -EBUSY; return -EBUSY;
} }
......
...@@ -1833,7 +1833,7 @@ int snd_wss_create(struct snd_card *card, ...@@ -1833,7 +1833,7 @@ int snd_wss_create(struct snd_card *card,
} }
chip->cport = cport; chip->cport = cport;
if (!(hwshare & WSS_HWSHARE_IRQ)) if (!(hwshare & WSS_HWSHARE_IRQ))
if (request_irq(irq, snd_wss_interrupt, IRQF_DISABLED, if (request_irq(irq, snd_wss_interrupt, 0,
"WSS", (void *) chip)) { "WSS", (void *) chip)) {
snd_printk(KERN_ERR "wss: can't grab IRQ %d\n", irq); snd_printk(KERN_ERR "wss: can't grab IRQ %d\n", irq);
snd_wss_free(chip); snd_wss_free(chip);
......
...@@ -465,13 +465,13 @@ snd_au1000_pcm_new(struct snd_au1000 *au1000) ...@@ -465,13 +465,13 @@ snd_au1000_pcm_new(struct snd_au1000 *au1000)
flags = claim_dma_lock(); flags = claim_dma_lock();
if ((au1000->stream[PLAYBACK]->dma = request_au1000_dma(DMA_ID_AC97C_TX, if ((au1000->stream[PLAYBACK]->dma = request_au1000_dma(DMA_ID_AC97C_TX,
"AC97 TX", au1000_dma_interrupt, IRQF_DISABLED, "AC97 TX", au1000_dma_interrupt, 0,
au1000->stream[PLAYBACK])) < 0) { au1000->stream[PLAYBACK])) < 0) {
release_dma_lock(flags); release_dma_lock(flags);
return -EBUSY; return -EBUSY;
} }
if ((au1000->stream[CAPTURE]->dma = request_au1000_dma(DMA_ID_AC97C_RX, if ((au1000->stream[CAPTURE]->dma = request_au1000_dma(DMA_ID_AC97C_RX,
"AC97 RX", au1000_dma_interrupt, IRQF_DISABLED, "AC97 RX", au1000_dma_interrupt, 0,
au1000->stream[CAPTURE])) < 0){ au1000->stream[CAPTURE])) < 0){
release_dma_lock(flags); release_dma_lock(flags);
return -EBUSY; return -EBUSY;
......
...@@ -1234,7 +1234,7 @@ static int sis_resume(struct pci_dev *pci) ...@@ -1234,7 +1234,7 @@ static int sis_resume(struct pci_dev *pci)
goto error; goto error;
} }
if (request_irq(pci->irq, sis_interrupt, IRQF_DISABLED|IRQF_SHARED, if (request_irq(pci->irq, sis_interrupt, IRQF_SHARED,
KBUILD_MODNAME, sis)) { KBUILD_MODNAME, sis)) {
printk(KERN_ERR "sis7019: unable to regain IRQ %d\n", pci->irq); printk(KERN_ERR "sis7019: unable to regain IRQ %d\n", pci->irq);
goto error; goto error;
...@@ -1340,7 +1340,7 @@ static int __devinit sis_chip_create(struct snd_card *card, ...@@ -1340,7 +1340,7 @@ static int __devinit sis_chip_create(struct snd_card *card,
if (rc) if (rc)
goto error_out_cleanup; goto error_out_cleanup;
if (request_irq(pci->irq, sis_interrupt, IRQF_DISABLED|IRQF_SHARED, if (request_irq(pci->irq, sis_interrupt, IRQF_SHARED,
KBUILD_MODNAME, sis)) { KBUILD_MODNAME, sis)) {
printk(KERN_ERR "unable to allocate irq %d\n", sis->irq); printk(KERN_ERR "unable to allocate irq %d\n", sis->irq);
goto error_out_cleanup; goto error_out_cleanup;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment