Commit 78456d6f authored by Linus Walleij's avatar Linus Walleij

Revert "gpio: convince line to become input in irq helper"

This reverts commit 7e7c059c.

I was wrong about trying to do this, as it breaks the
orthogonality between gpiochips and irqchips.
Signed-off-by: Linus Walleij's avatarLinus Walleij <>
parent da17f8a1
......@@ -1510,25 +1510,6 @@ static int gpiochip_irq_reqres(struct irq_data *d)
if (!try_module_get(chip->gpiodev->owner))
return -ENODEV;
* If it is possible to switch this GPIO to an input
* this is a good time to do it.
if (chip->direction_input) {
struct gpio_desc *desc;
int ret;
desc = gpiochip_get_desc(chip, d->hwirq);
if (IS_ERR(desc))
return PTR_ERR(desc);
ret = chip->direction_input(chip, d->hwirq);
if (ret)
return ret;
clear_bit(FLAG_IS_OUT, &desc->flags);
if (gpiochip_lock_as_irq(chip, d->hwirq)) {
"unable to lock HW IRQ %lu for IRQ\n",
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment