Commit 6ff38bd4 authored by Pavel Tikhomirov's avatar Pavel Tikhomirov Committed by Linus Torvalds

mm: cleancache: fix corruption on missed inode invalidation

If all pages are deleted from the mapping by memory reclaim and also
moved to the cleancache:

  (no shadow case)
    mapping->nrpages -= nr
    (nrpages becomes 0)

We don't clean the cleancache for an inode after final file truncation

  check (nrpages || nrexceptional) is false
    no truncate_inode_pages
      no cleancache_invalidate_inode(mapping)

These way when reading the new file created with same inode we may get
these trash leftover pages from cleancache and see wrong data instead of
the contents of the new file.

Fix it by always doing truncate_inode_pages which is already ready for
nrpages == 0 && nrexceptional == 0 case and just invalidates inode.

[ add comment, per Jan]
Fixes: commit 91b0abe3 ("mm + fs: store shadow entries in page cache")
Signed-off-by: default avatarPavel Tikhomirov <>
Reviewed-by: default avatarVasily Averin <>
Reviewed-by: default avatarAndrey Ryabinin <>
Reviewed-by: Jan Kara's avatarJan Kara <>
Cc: Johannes Weiner <>
Cc: Mel Gorman <>
Cc: Matthew Wilcox <>
Cc: Andi Kleen <>
Cc: <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent e21e5744
......@@ -517,9 +517,13 @@ void truncate_inode_pages_final(struct address_space *mapping)
truncate_inode_pages(mapping, 0);
* Cleancache needs notification even if there are no pages or shadow
* entries.
truncate_inode_pages(mapping, 0);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment