Commit 0f4bbb23 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Linus Walleij

gpio: GPIO_GET_CHIPINFO_IOCTL: Fix information leak

The GPIO_GET_CHIPINFO_IOCTL handler allocates a gpiochip_info struct on the
stack and then passes it to copy_to_user(). But depending on the length of
the GPIO chip name and label the struct is only partially initialized.

This exposes the previous, potentially sensitive, stack content to the
issuing userspace application. To avoid this make sure that the struct is
fully initialized.

Fixes: 521a2ad6 ("gpio: add userspace ABI for GPIO line information")
Signed-off-by: default avatarLars-Peter Clausen <>
Signed-off-by: Linus Walleij's avatarLinus Walleij <>
parent 1f1cc456
......@@ -823,6 +823,8 @@ static long gpio_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
struct gpiochip_info chipinfo;
memset(&chipinfo, 0, sizeof(chipinfo));
strncpy(, dev_name(&gdev->dev),
sizeof(;[sizeof(] = '\0';
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment