• Dan Carpenter's avatar
    CodingStyle: add some more error handling guidelines · ea040360
    Dan Carpenter authored
    I added a paragraph on choosing label names, and updated the example
    code to use a better label name.  I also cleaned up the example code to
    more modern style by moving the allocation out of the initializer and
    changing the NULL check.
    Perhaps the most common type of error handling bug in the kernel is "one
    err bugs".  CodingStyle already says that we should "avoid nesting" by
    using error labels and one err style error handling tends to have
    multiple indent levels, so this was already bad style.  But I've added a
    new paragraph explaining how to avoid one err bugs by using multiple
    error labels which is, hopefully, more clear.
    Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
    [jc: added GFP_KERNEL to kmalloc() call]
    Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
CodingStyle 33.7 KB