• jiangyiwen's avatar
    ocfs2/dlm: wait until DLM_LOCK_RES_SETREF_INPROG is cleared in dlm_deref_lockres_worker · b5560143
    jiangyiwen authored
    Commit f3f85464 ("ocfs2_dlm: Ensure correct ordering of set/clear
    refmap bit on lockres") still exists a race which can't ensure the
    ordering is exactly correct.
    Node1               Node2                    Node3
    umount, migrate
    lockres to Node2
                        migrate finished,
                        send migrate request
                        to Node3
                                                  received migrate request,
                                                  create a migration_mle,
                                                  respond to Node2.
                        set DLM_LOCK_RES_SETREF_INPROG
                        and send assert master to
                                                  delete migration_mle in
                                                  Node3 umount without response
                                                  dlm_thread purge
                                                  this lockres, send drop
                                                  deref message to Node2
                        found the flag of
                        is set, dispatch
                        dlm_deref_lockres_worker to
                        clear refmap, but in function of
                        only if node in refmap it wait
                        to be cleared. So worker is
                        done successfully
                                                  purge lockres, send
                                                  assert master response
                                                  to Node1, and finish umount
                        set Node3 in refmap, and it
                        won't be cleared forever, thus
                        lead to umount hung
    so wait until DLM_LOCK_RES_SETREF_INPROG is cleared in
    Signed-off-by: default avatarYiwen Jiang <jiangyiwen@huawei.com>
    Reviewed-by: default avatarJoseph Qi <joseph.qi@huawei.com>
    Reviewed-by: default avatarJunxiao Bi <junxiao.bi@oracle.com>
    Cc: Mark Fasheh <mfasheh@suse.de>
    Cc: Joel Becker <jlbec@evilplan.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
dlmmaster.c 96 KB