Skip to content
  • Arnaldo Carvalho de Melo's avatar
    perf report: Fix rbtree bug · a4c43bea
    Arnaldo Carvalho de Melo authored
    Ingo Molnar reported:
    
    > FYI, i just got this crash (segfault) in perf report after
    > collecting a long profile from Xorg:
    >
    > Starting program: /home/mingo/tip/Documentation/perf_counter/perf report
    > [Thread debugging using libthread_db enabled]
    > Detaching after fork from child process 20008.
    > [New Thread 0x7f92fd62a6f0 (LWP 20005)]
    >
    > Program received signal SIGSEGV, Segmentation fault.
    > 0x000000000041031a in __rb_erase_color (node=0x142c0901, parent=0x0,
    > root=0x881918)
    >     at util/rbtree.c:143
    > 143			if (parent->rb_left == node)
    
    It was a problem introduced in this cset:
    
     perf report: Fix comm sorting - 8229289b
    
    
    
    This patch should fix it.
    
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Acked-by: default avatarPeter Zijlstra <peterz@infradead.org>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
    Cc: Marcelo Tosatti <mtosatti@redhat.com>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Stephane Eranian <eranian@googlemail.com>
    LKML-Reference: <new-submission>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    a4c43bea