• Herbert Xu's avatar
    [NEIGH] Fix timer leak in neigh_changeaddr · 49636bb1
    Herbert Xu authored
    neigh_changeaddr attempts to delete neighbour timers without setting
    nud_state.  This doesn't work because the timer may have already fired
    when we acquire the write lock in neigh_changeaddr.  The result is that
    the timer may keep firing for quite a while until the entry reaches
    It should be setting the nud_state straight away so that if the timer
    has already fired it can simply exit once we relinquish the lock.
    In fact, this whole function is simply duplicating the logic in
    neigh_ifdown which in turn is already doing the right thing when
    it comes to deleting timers and setting nud_state.
    So all we have to do is take that code out and put it into a common
    function and make both neigh_changeaddr and neigh_ifdown call it.
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
neighbour.c 62.2 KB