Skip to content
  • Sasha Levin's avatar
    virtio_pci: defer kfree until release callback · 63bd62a0
    Sasha Levin authored and Michael S. Tsirkin's avatar Michael S. Tsirkin committed
    
    
    A struct device which has just been unregistered can live on past the
    point at which a driver decides to drop it's initial reference to the
    kobject gained on allocation.
    
    This implies that when releasing a virtio device, we can't free a struct
    virtio_device until the underlying struct device has been released,
    which might not happen immediately on device_unregister().
    
    Unfortunately, this is exactly what virtio pci does:
    it has an empty release callback, and frees memory immediately
    after unregistering the device.
    
    This causes an easy to reproduce crash if CONFIG_DEBUG_KOBJECT_RELEASE
    it enabled.
    
    To fix, free the memory only once we know the device is gone in the release
    callback.
    
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    
    63bd62a0