• Takashi Iwai's avatar
    ALSA: hda - Apply pin-enablement workaround to all Haswell HDMI codecs · 17df3f55
    Takashi Iwai authored
    This is a revised patch based on Mengdong Lin's fix patch, which is a
    supplement to a previous patch [1611a9c9: ALSA: hda - Add fixup for
    Haswell to enable all pin and convertor widgets].
    Some Haswell BIOS will disable the 2nd and 3rd pin/covertor widgets
    when the HD-A controller changes state from D3 to D0.  So when the
    controller resumes after a system or runtime suspend, these widgets
    are disabled and programming these widgets to D0 will cause H/W error
    and codec will not respond.
    In addition, we found out that some BIOS disables the pins at S3
    although it shows up at boot.  This confuses the driver utterly, and
    the hardware falls into the fatal communication error like the above.
    So in this patch, we apply intel_haswell_enable_all_pins() not only as
    a fixup to a certain device (with 8086:2010) but to all Haswell
    machines.  The codec driver basically assumes that all pins are
    exposed, so it's anyway better to see them from the beginning.  Even
    if all pins and converters are shown by this call, there should be no
    regression in practice: the pin default configurations are still kept,
    thus the disabled pins are handled as disabled by the driver
    Signed-off-by: default avatarMengdong Lin <mengdong.lin@intel.com>
    Signed-off-by: Takashi Iwai's avatarTakashi Iwai <tiwai@suse.de>
patch_hdmi.c 73.3 KB