Commit 966f848e authored by Tim-Philipp Müller's avatar Tim-Philipp Müller 🐠

replaygain: fix taglist leak in rganalysis

And add some FIXMEs.
parent cc4f9853
......@@ -532,6 +532,7 @@ gst_rg_analysis_stop (GstBaseTransform * base)
return TRUE;
}
/* FIXME: handle global vs. stream-tags? */
static void
gst_rg_analysis_handle_tags (GstRgAnalysis * filter,
const GstTagList * tag_list)
......@@ -632,9 +633,10 @@ gst_rg_analysis_handle_eos (GstRgAnalysis * filter)
GST_LOG_OBJECT (filter, "posting tag list with results");
gst_tag_list_add (tag_list, GST_TAG_MERGE_APPEND,
GST_TAG_REFERENCE_LEVEL, filter->reference_level, NULL);
/* This steals our reference to the list: */
gst_pad_push_event (GST_BASE_TRANSFORM_SRC_PAD (GST_BASE_TRANSFORM
(filter)), gst_event_new_tag (gst_tag_list_ref (tag_list)));
/* This takes ownership of our reference to the list */
gst_pad_push_event (GST_BASE_TRANSFORM_SRC_PAD (filter),
gst_event_new_tag (tag_list));
tag_list = NULL;
}
}
......@@ -653,6 +655,7 @@ gst_rg_analysis_handle_eos (GstRgAnalysis * filter)
g_object_notify (G_OBJECT (filter), "num-tracks");
}
/* FIXME: return tag list (lists?) based on input tags.. */
static gboolean
gst_rg_analysis_track_result (GstRgAnalysis * filter, GstTagList ** tag_list)
{
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment