Skip to content

GitLab

Switch branch/tag
  1. 08 Sep, 2020 3 commits
  3. 07 Sep, 2020 4 commits
  5. 04 Sep, 2020 1 commit
  7. 01 Sep, 2020 4 commits
    • Roman Gilg's avatar
      xwayland: Replace need_rotate boolean with simple check on xdg-output · 727df0a7
      Roman Gilg authored and Olivier Fourdan's avatar Olivier Fourdan committed 
      

The need_rotate variable is only used once anymore and had semantics which lead
to errors in the past. In particular when negated we are dealing with a double
negation.

The variable gets replaced with a simple check on the xdg-output directly.
Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      727df0a7
    • Roman Gilg's avatar
      Revert "xserver: Fix a typo" · da791ed9
      Roman Gilg authored and Olivier Fourdan's avatar Olivier Fourdan committed 
      This reverts commit 427f8bc0.

When receiving an output update for the mode size we need to rotate the stored
width and height values if and only if we have an xdg-output for this output
since in this case the stored values describe the output's size in logical
space, i.e. rotated.

The here reverted commit made a code change with which we would not rotate though
when an xdg-output was available since in this case the need_rotate variable was
set to False what caused in the check afterwards the first branch to execute.
      da791ed9
    • Roman Gilg's avatar
      xwayland: Switch width and height argument order · 92f4a9ad
      Roman Gilg authored and Olivier Fourdan's avatar Olivier Fourdan committed 
      

That is just a small style-change to the output_get_new_size function. The
function before did take first the height and then the width argument, what
is unusual since resolutions are normally named the other way around, for
example 1920x1080. Also compare the update_screen_size function.

Therefore change the order of arguments for output_get_new_size.
Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      92f4a9ad
    • Roman Gilg's avatar
      xwayland: simplify output_get_new_size function · 1805383d
      Roman Gilg authored and Olivier Fourdan's avatar Olivier Fourdan committed 
      

We can just read out the xdg_output field of the provided xwl_output to check
if a rotation is necessary or not.

This makes the function easier to understand. Additionally some documentation
is added.
Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      1805383d
  9. 31 Aug, 2020 1 commit
  11. 25 Aug, 2020 8 commits
  13. 24 Aug, 2020 1 commit
  15. 18 Aug, 2020 1 commit
  17. 04 Aug, 2020 1 commit
  19. 31 Jul, 2020 2 commits
  21. 30 Jul, 2020 1 commit
  23. 29 Jul, 2020 2 commits
  25. 28 Jul, 2020 1 commit
    • Huacai Chen's avatar
      linux: Fix platform device probe for DT-based PCI · 9fbd3e43
      Huacai Chen authored 
      

On a DT-base PCI platform, the sysfs path of vga device is like this:
/sys/devices/platform/bus@10000000/1a000000.pci/pci0000:00/0000:00:11.0/0000:04:00.0.

Then the ID_PATH from udev is platform-1a000000.pci-pci-0000:04:00.0 and
the BusID will be pci-0000:04:00.0, which causes Xorg start fail. This
is because config_udev_odev_setup_attribs() use strstr() to search the
first "pci-" in ID_PATH. To fix this, we implement a strrstr() function
and use it to search the last "pci-" in ID_PATH, which can get a correct
BusID.
Signed-off-by: default avatarHuacai Chen <chenhc@lemote.com>
      9fbd3e43
  27. 24 Jul, 2020 1 commit
    • Roman Gilg's avatar
      present: Check valid region in window mode flips · 591916ea
      Roman Gilg authored 
      

For Pixmap flips to have well defined outcomes the window must be contained by
the valid region if such region was specified.

The valid region is inserted as an argument to the check in window mode.
Setting this argument is missing in screen mode as well but we ignore it for now
and only add it to window mode.

It seems there are none or only very few clients actually making use of valid
regions at the moment. For simplicity we therefore just check if a valid region
was set by the client and in this case do never flip, independently of the
window being contained by the region or not.
Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      591916ea
  29. 22 Jul, 2020 5 commits
    • Roman Gilg's avatar
      present: Remove superfluous set abort flip function in window mode · bf794bd7
      Roman Gilg authored 
      

The function is never called from present_screen.c in contrast to the behavior
in screen mode.

In present_wnmd.c we can simply remove the function which does an unnecessary
check of the property before setting it and directly set the property at the
two locations the function was called previously.
Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      bf794bd7
    • Roman Gilg's avatar
      present: Idle vblanks any time in window mode · ab880b8b
      Roman Gilg authored 
      

With the newly introduced separate API method for idling a presented Pixmap in
window mode we can simplify the logic by allowing calls to it at any point in
time.

This is done by setting the flip_idler flag if the Pixmap was idled before
being presented.
Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      ab880b8b
    • Roman Gilg's avatar
      present: Notify via distinct API functions in window mode · 932c6bac
      Roman Gilg authored 
      

Notifying Present about events' states was done prior with the single function
present_wnmd_event_notify just like in screen mode. But it is more intelligible
if at least in window mode we make use of three different functions with names
that directly indicate what their purpose is:

* present_wnmd_event_notify only for queued events feedback.
* present_wnmd_flip_notify for when a presentation occured (flip).
* present_wnmd_idle_notify for when the Pixmap of the event can be reused.

This is an API-breaking change in regards to window mode. DDX written against
the previous version won't work anymore. It is assumed that there only exists
the XWayland DDX at the moment using the window mode such that this is not an
issue for the overall ecosystem.
Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      932c6bac
    • Roman Gilg's avatar
      xwayland: Rename present event lists · f8211095
      Roman Gilg authored 
      

Rename the lists release_queue to release_list and event_list to
wait_list.

The prior names release_queue and event_list were ambiguous: in both are event-
like vblanks which can be removed from the lists in random order. In the
release_queue can be flips that are already released but still wait for the
sync or frame callback but normally the release comes later. In the event_list
are queued events waiting for a later msc.
Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      f8211095
    • Roman Gilg's avatar
      xwayland: Remove unused xwl_screen entry · 0db326e5
      Roman Gilg authored 
      

In xwl_present_window an xwl_screen entry was declared but never actually used.
Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      0db326e5
  31. 21 Jul, 2020 4 commits
    • Alex Goins's avatar
      randr: Re-add removed NULL checks to xf86RandR12.c · 495bf63a
      Alex Goins authored 
      Commit 1e3f9ea1

 removed some NULL checks from xf86RandR12.c, on the premise that
they can't be reached unless RandR has already been initialized. For threesuch
calls, that's not true:

xf86Crtc.c::xf86CrtcScreenInit():

    if (c == config->num_crtc) {
        xf86RandR12SetRotations(screen, RR_Rotate_0 | RR_Rotate_90 |
                                RR_Rotate_180 | RR_Rotate_270 |
                                RR_Reflect_X | RR_Reflect_Y);
        xf86RandR12SetTransformSupport(screen, TRUE);
    }
    else {
        xf86RandR12SetRotations(screen, RR_Rotate_0);
        xf86RandR12SetTransformSupport(screen, FALSE);
    }

xf86Crtc.c::xf86CrtcCloseScreen():

    xf86RandR12CloseScreen(screen);

This change adds checks back to xf86RandR12Set{Rotations,TransformSupport}() and
xf86RandR12CloseScreen(), checking that xf86RandR12KeyRec has been registered.
Without this, X will hit an assert that causes it to abort.
Signed-off-by: Alex Goins's avatarAlex Goins <agoins@nvidia.com>
      495bf63a
    • Alex Goins's avatar
      randr: Check rrPrivKey in RRHasScanoutPixmap() · 8eeff5d7
      Alex Goins authored 
      RRHasScanoutPixmap() is called from xf86CheckHWCursor(), regardless of whether
or not RandR has been initialized.

As mentioned in commit 4226c6d0, it's possible that RandR has not been
initialized if the server is configured with Xinerama and there is more than one
X screen. Calling rrGetScrPriv when RandR isn't initialized causes an assertion
failure that aborts the server:

      Xorg: ../include/privates.h:121: dixGetPrivateAddr: Assertion
      key->initialized' failed.

Just as in commit 4226c6d0

, fix the problem by checking
dixPrivateKeyRegistered(rrPrivKey) before calling rrGetScrPriv.
Signed-off-by: Alex Goins's avatarAlex Goins <agoins@nvidia.com>
      8eeff5d7
    • Alex Goins's avatar
      randr: Check rrPrivKey before autobinding GPU screens · 6172bd2b
      Alex Goins authored 
      RRProviderAutoConfigGpuScreen() is called from outside RandR, so there is no
guarantee that RandR has been initialized when it is called.

As mentioned in commit 4226c6d0, it's possible that RandR has not been
initialized if the server is configured with Xinerama and there is more than one
X screen. Calling rrGetScrPriv when RandR isn't initialized causes an assertion
failure that aborts the server:

  Xorg: ../include/privates.h:121: dixGetPrivateAddr: Assertion
  key->initialized' failed.

Just as in commit 4226c6d0

, fix the problem by checking
dixPrivateKeyRegistered(rrPrivKey) before calling rrGetScrPriv.
Signed-off-by: Alex Goins's avatarAlex Goins <agoins@nvidia.com>
      6172bd2b
    • Michel Dänzer's avatar
      xwayland: Handle NULL xwl_seat in xwl_seat_can_emulate_pointer_warp · e33453f9
      Michel Dänzer authored and Michel Dänzer's avatar Michel Dänzer committed 
      

This can happen e.g. with weston's headless backend.
Reviewed-by: Olivier Fourdan's avatarOlivier Fourdan <ofourdan@redhat.com>
      e33453f9