1. 22 Sep, 2020 1 commit
    • Olivier Fourdan's avatar
      xwayland: Add a flag to expose EGL backend features · ae84f14f
      Olivier Fourdan authored
      
      
      The present flip does not work with the EGLStream backend. Similarly,
      the EGLStream backend does not require the buffer to be flushed as
      eglSwapBuffers() should take care of this.
      
      Instead of actually checking the backend in use in the present code,
      add a flag in the form of a bitfield to the EGL backend to indicate
      its features and requirements.
      
      This should not introduce any functional change.
      
      v2: Fix logical test (Adam Jackson <ajax@redhat.com>)
      Signed-off-by: default avatarOlivier Fourdan <ofourdan@redhat.com>
      Reviewed-by: Adam Jackson's avatarAdam Jackson <ajax@redhat.com>
      ae84f14f
  2. 21 Sep, 2020 1 commit
  3. 07 Sep, 2020 1 commit
  4. 01 Sep, 2020 4 commits
    • Roman Gilg's avatar
      xwayland: Replace need_rotate boolean with simple check on xdg-output · 727df0a7
      Roman Gilg authored
      
      
      The need_rotate variable is only used once anymore and had semantics which lead
      to errors in the past. In particular when negated we are dealing with a double
      negation.
      
      The variable gets replaced with a simple check on the xdg-output directly.
      Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      727df0a7
    • Roman Gilg's avatar
      Revert "xserver: Fix a typo" · da791ed9
      Roman Gilg authored
      This reverts commit 427f8bc0.
      
      When receiving an output update for the mode size we need to rotate the stored
      width and height values if and only if we have an xdg-output for this output
      since in this case the stored values describe the output's size in logical
      space, i.e. rotated.
      
      The here reverted commit made a code change with which we would not rotate though
      when an xdg-output was available since in this case the need_rotate variable was
      set to False what caused in the check afterwards the first branch to execute.
      da791ed9
    • Roman Gilg's avatar
      xwayland: Switch width and height argument order · 92f4a9ad
      Roman Gilg authored
      
      
      That is just a small style-change to the output_get_new_size function. The
      function before did take first the height and then the width argument, what
      is unusual since resolutions are normally named the other way around, for
      example 1920x1080. Also compare the update_screen_size function.
      
      Therefore change the order of arguments for output_get_new_size.
      Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      92f4a9ad
    • Roman Gilg's avatar
      xwayland: simplify output_get_new_size function · 1805383d
      Roman Gilg authored
      
      
      We can just read out the xdg_output field of the provided xwl_output to check
      if a rotation is necessary or not.
      
      This makes the function easier to understand. Additionally some documentation
      is added.
      Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      1805383d
  5. 04 Aug, 2020 1 commit
  6. 30 Jul, 2020 1 commit
  7. 22 Jul, 2020 4 commits
    • Roman Gilg's avatar
      present: Idle vblanks any time in window mode · ab880b8b
      Roman Gilg authored
      
      
      With the newly introduced separate API method for idling a presented Pixmap in
      window mode we can simplify the logic by allowing calls to it at any point in
      time.
      
      This is done by setting the flip_idler flag if the Pixmap was idled before
      being presented.
      Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      ab880b8b
    • Roman Gilg's avatar
      present: Notify via distinct API functions in window mode · 932c6bac
      Roman Gilg authored
      
      
      Notifying Present about events' states was done prior with the single function
      present_wnmd_event_notify just like in screen mode. But it is more intelligible
      if at least in window mode we make use of three different functions with names
      that directly indicate what their purpose is:
      
      * present_wnmd_event_notify only for queued events feedback.
      * present_wnmd_flip_notify for when a presentation occured (flip).
      * present_wnmd_idle_notify for when the Pixmap of the event can be reused.
      
      This is an API-breaking change in regards to window mode. DDX written against
      the previous version won't work anymore. It is assumed that there only exists
      the XWayland DDX at the moment using the window mode such that this is not an
      issue for the overall ecosystem.
      Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      932c6bac
    • Roman Gilg's avatar
      xwayland: Rename present event lists · f8211095
      Roman Gilg authored
      
      
      Rename the lists release_queue to release_list and event_list to
      wait_list.
      
      The prior names release_queue and event_list were ambiguous: in both are event-
      like vblanks which can be removed from the lists in random order. In the
      release_queue can be flips that are already released but still wait for the
      sync or frame callback but normally the release comes later. In the event_list
      are queued events waiting for a later msc.
      Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      f8211095
    • Roman Gilg's avatar
      xwayland: Remove unused xwl_screen entry · 0db326e5
      Roman Gilg authored
      
      
      In xwl_present_window an xwl_screen entry was declared but never actually used.
      Signed-off-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      0db326e5
  8. 21 Jul, 2020 1 commit
  9. 20 Jul, 2020 2 commits
  10. 16 Jul, 2020 1 commit
    • Lyude Paul's avatar
      xwayland: Store xwl_tablet_pad in its own private key · ba0e789b
      Lyude Paul authored
      
      
      When a slave device causes the master virtual pointer device to change
      device types, the device's private data pointer
      (device->public.devicePrivate) is also changed to match the type of the
      slave device. This can be a problem though, as tablet pad devices will
      set the device's private data pointer to their own xwl_tablet_pad
      struct. This can cause us to dereference the pointer as the wrong type,
      and result in a segfault:
      
      Thread 1 "Xwayland" received signal SIGSEGV, Segmentation fault.
      wl_proxy_marshal (proxy=0x51, opcode=opcode@entry=0) at src/wayland-client.c:792
      792             va_start(ap, opcode);
      (gdb) bt
      0  wl_proxy_marshal (proxy=0x51, opcode=opcode@entry=0) at
        src/wayland-client.c:792
      1  0x00005610b27b6c55 in wl_pointer_set_cursor (hotspot_y=0,
        hotspot_x=0, surface=0x0, serial=<optimized out>, wl_pointer=<optimized
        out>) at /usr/include/wayland-client-protocol.h:4610
      2  xwl_seat_set_cursor (xwl_seat=xwl_seat@entry=0x5610b46d5d10) at
        xwayland-cursor.c:137
      3  0x00005610b27b6ecd in xwl_set_cursor (device=<optimized out>,
        screen=<optimized out>, cursor=<optimized out>, x=<optimized out>,
        y=<optimized out>) at xwayland-cursor.c:249
      4  0x00005610b2800b46 in miPointerUpdateSprite (pDev=0x5610b4501a30) at
        mipointer.c:468
      5  miPointerUpdateSprite (pDev=0x5610b4501a30) at mipointer.c:410
      6  0x00005610b2800e56 in miPointerDisplayCursor (pCursor=0x5610b4b35740,
        pScreen=0x5610b3d54410, pDev=0x5610b4501a30) at mipointer.c:206
      7  miPointerDisplayCursor (pDev=0x5610b4501a30, pScreen=0x5610b3d54410,
        pCursor=0x5610b4b35740) at mipointer.c:194
      8  0x00005610b27ed62b in CursorDisplayCursor (pDev=<optimized out>,
        pScreen=0x5610b3d54410, pCursor=0x5610b4b35740) at cursor.c:168
      9  0x00005610b28773ee in AnimCurDisplayCursor (pDev=0x5610b4501a30,
        pScreen=0x5610b3d54410, pCursor=0x5610b4b35740) at animcur.c:197
      10 0x00005610b28eb4ca in ChangeToCursor (pDev=0x5610b4501a30,
        cursor=0x5610b4b35740) at events.c:938
      11 0x00005610b28ec99f in WindowHasNewCursor
        (pWin=pWin@entry=0x5610b4b2e0c0) at events.c:3362
      12 0x00005610b291102d in ChangeWindowAttributes (pWin=0x5610b4b2e0c0,
        vmask=<optimized out>, vlist=vlist@entry=0x5610b4c41dcc,
        client=client@entry=0x5610b4b2c900) at window.c:1561
      13 0x00005610b28db8e3 in ProcChangeWindowAttributes (client=0x5610b4b2c900)
        at dispatch.c:746
      14 0x00005610b28e1e5b in Dispatch () at dispatch.c:497
      15 0x00005610b28e5f34 in dix_main (argc=16, argv=0x7ffc7a601b68,
        envp=<optimized out>) at main.c:276
      16 0x00007f8828cde042 in __libc_start_main (main=0x5610b27ae930 <main>,
        argc=16, argv=0x7ffc7a601b68, init=<optimized out>, fini=<optimized
        out>, rtld_fini=<optimized out>, stack_end=0x7ffc7a601b58) at
        ../csu/libc-start.c:308
      17 0x00005610b27ae96e in _start () at cursor.c:1064
      
      Simple reproducer in gnome-shell: open up an Xwayland window, press some
      tablet buttons, lock and unlock the screen. Repeat if it doesn't crash
      the first time.
      
      So, let's fix this by registering our own device-specific private key
      for storing a backpointer to xwl_tablet_pad, so that all input devices
      have their private data pointers set to their respective xwl_seat.
      Reviewed-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      Signed-off-by: Lyude Paul's avatarLyude Paul <lyude@redhat.com>
      ba0e789b
  11. 14 Jul, 2020 1 commit
  12. 08 Jul, 2020 1 commit
    • Olivier Fourdan's avatar
      xwayland: Add a pkg-config file for Xwayland · 5188603f
      Olivier Fourdan authored
      
      
      Xwayland is usually spawned by the Wayland compositor which sets the
      command line options.
      
      If a command line option is not supported, Xwayland will fail to start.
      
      That somehow makes the Xwayland command line option sort of ABI, the
      Wayland compositor need to know if a particular option is supported by
      Xwayland at build time.
      
      Also, currently, Xwayland is being installed along with the rest of the
      common executable programs that users may run, which is sub-optimal
      because, well, Xwayland is not a common executable program, it's meant
      to be a proxy between the Wayland compositor and the legacy X11 clients
      which wouldn't be able to run on Wayland otherwise.
      
      Xwayland would be better installed in `libexec` but that directory is
      (purposedly) not in the user `PATH` and therefore the Wayland compositor
      may not be able to find Xwayland in that case.
      
      To solve both problems (which options are supported by Xwayland and
      where to look for it), add a `pkg-config` file specifically for Xwayland
      which gives the full path to Xwayland (`xwayland`) and which options it
      supports (using `pkg-config` variables).
      
      The `pkg-config` file also provides the `Version` so the build scripts
      can check for a particular version if necessary.
      
      Obviously, Wayland compositors are not required to use the `pkg-config`
      file and can continue to use whatever mechanism they deem preferable.
      Signed-off-by: default avatarOlivier Fourdan <ofourdan@redhat.com>
      Reviewed-by: Michel Dänzer's avatarMichel Dänzer <mdaenzer@redhat.com>
      5188603f
  13. 07 Jul, 2020 4 commits
  14. 05 Jul, 2020 1 commit
  15. 03 Jul, 2020 2 commits
    • Olivier Fourdan's avatar
      xwayland: Use a fixed DPI value for core protocol · b0413b6e
      Olivier Fourdan authored
      
      
      The way Xwayland works (like all Wayland clients), it first queries the
      Wayland registry, set up all relevant protocols and then initializes its
      own structures.
      
      That means Xwayland will get the Wayland outputs from the Wayland
      compositor, compute the physical size of the combined outputs and set
      the corresponding Xwayland screen properties accordingly.
      
      Then it creates the X11 screen using fbScreenInit() but does so by using
      a default DPI value of 96. That value is used to set the physical size
      of the X11 screen, hence overriding the value computed from the actual
      physical size provided by the Wayland compositor.
      
      As a result, the DPI computed by tools such as xdpyinfo will always be
      96 regardless of the actual screen size and resolution.
      
      However, if the Wayland outputs get reconfigured, or new outputs added,
      or existing outputs removed, Xwayland will recompute and update the
      physical size of the screen, leading to an unexpected change of DPI.
      
      To avoid that discrepancy, use a fixed size DPI (defaults to 96, and can
      be set using the standard command lime option "-dpi") and compute a
      physical screen size to match that DPI setting.
      
      Note that only affects legacy core protocols, X11 clients can still get
      the actual physical output size as reported by the Wayland compositor
      using the RandR protocol, which also allows for the size to be 0 if the
      size is unknown or meaningless.
      Signed-off-by: default avatarOlivier Fourdan <ofourdan@redhat.com>
      Reviewed-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
      Closes: xorg/xserver#731
      b0413b6e
    • SimonPilkington's avatar
      xwayland: Initialise values in xwlVidModeGetGamma() · 6748a409
      SimonPilkington authored
      ProcVidModeGetGamma() relies on GetGamma() to initialise values if it
      returns TRUE. Without this, we're sending uninitialised values to
      clients.
      
      Fixes: #1040
      6748a409
  16. 02 Jul, 2020 1 commit
  17. 25 Jun, 2020 2 commits
  18. 19 Jun, 2020 3 commits
  19. 05 Jun, 2020 1 commit
    • Adam Jackson's avatar
      xwayland: Set the vendor name for GLX_EXT_libglvnd · fc4f2485
      Adam Jackson authored
      Without this the client library will flail around looking for a default
      provider, probably one named "indirect", and that defeats the point of
      having the EGL provider for direct context support in the first place.
      
      This assumes that "mesa" will work, of course, and in general it should.
      Mesa drivers will DTRT through the DRI3 setup path, and if our glamor is
      atop something non-Mesa then you should fall back to llvmpipe like 1.20.
      In the future it might be useful to differentiate the vendor here based
      on whether glamor is using gbm or streams.
      
      Fixes: xorg/xserver#1032
      fc4f2485
  20. 20 May, 2020 1 commit
  21. 18 May, 2020 1 commit
  22. 13 May, 2020 1 commit
    • Carlos Garnacho's avatar
      xwayland: Improve checks for confined_to on InputOnly windows · 0777cf46
      Carlos Garnacho authored
      
      
      In this pretty Wine/Proton specific kludge, we try to handle confining grabs
      on InputOnly windows by trying to find the InputOutput window that the pointer
      would get visually confined to.
      
      The grabbing window and the visible window come from different clients, so
      we used to simply resort to the pointer focus. This is troublesome though, as
      the call may happen very soon at a time that the toplevel wasn't yet mapped by
      the Wayland compositor, so the pointer focus may well be out of date soon.
      
      In these situations, it does seem that even though the confining grab happens
      too early to have the wayland surface mapped, the xserver view of the WindowPtr
      does already reflect the size. Use this to find out the better window to
      assign the confining grab to, one whose geometry fully contains the InputOnly
      window's.
      Signed-off-by: Carlos Garnacho's avatarCarlos Garnacho <carlosg@gnome.org>
      Reviewed-by: default avatarOlivier Fourdan <ofourdan@redhat.com>
      0777cf46
  23. 12 May, 2020 4 commits