- 06 Nov, 2019 1 commit
-
-
Olivier Fourdan authored
`glGetString(GL_VERSION)` will return NULL without a current context. Commit dabc7d8b (“xwayland: Fall back to GLES2 if we don't get at least GL 2.1 in glamor”) would check the context is created, but it is made current just after, so the call to `epoxy_gl_version()` would return 0, hence defeating the version check. Make the context current prior to call `epoxy_gl_version()`. Fixes: dabc7d8b - xwayland: Fall back to GLES2 if we don't get at least GL 2.1 in glamor Closes: xorg/xserver#932 xorg/xserver!324 Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com>
-
- 05 Nov, 2019 1 commit
-
-
Some particularly unfortunate hardware (Intel gen3, mostly) will give you GLES2 but not GL 2.1. Fall back to GLES2 for such cases so you still get accelerated GLX.
-
- 04 Nov, 2019 1 commit
-
-
Hans de Goede authored
Define EGL_NO_X11 everywhere were we also define MESA_EGL_NO_X11_HEADERS, EGL_NO_X11 is the MESA_EGL_NO_X11_HEADERS equivalent for the egl headers shipped with libglvnd. This fixes the xserver not building with the libglvnd-1.2.0 headers: In file included from /usr/include/EGL/eglplatform.h:128, from /usr/include/epoxy/egl_generated.h:11, from /usr/include/epoxy/egl.h:46, from glamor_priv.h:43, from glamor_composite_glyphs.c:25: /usr/include/X11/Xlib.h:222:2: error: conflicting types for 'GC' 222 | *GC; | ^~ In file included from glamor.h:34, from glamor_priv.h:32, from glamor_composite_glyphs.c:25: ../include/gcstruct.h:282:3: note: previous declaration of 'GC' was here 282 | } GC; | ^~ Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
- 30 Oct, 2019 18 commits
-
-
v2: Set the define for xha1.c programatically, rather than using loads of conditionals.
-
SourceValidate handles this for us consistently now. Reviewed-by:
Michel Dänzer <mdaenzer@redhat.com>
-
SourceValidate handles this for us consistently now. Reviewed-by:
Michel Dänzer <mdaenzer@redhat.com>
-
This ensures that any prep work for the drawable we're about to read from is already done before we call down to GetImage. This should be no functional change as most of the callers with a non-trivial SourceValidate are already wrapping GetImage and doing the equivalent thing, but we'll be simplifying that shortly. More importantly this ensures that if any of that prep work would generate events - like automatic compositing flushing rendering to a parent pixmap which then triggers damage - then it happens entirely before we start writing the GetImage reply header. Note that we do not do the same for GetSpans, but that's okay. The only way to get to GetSpans is through miCopyArea or miCopyPlane - where the callers must already call SourceValidate - or miGetImage - which this commit now protects with SourceValidate. Fixes: xorg/xserver#902 Reviewed-by:
Michel Dänzer <mdaenzer@redhat.com>
-
Slightly simplifies the callers since they don't need to check for non-NULL anymore. I do extremely hate the workarounds here to suppress misprite taking the cursor down though. Surely there's a better way. Reviewed-by:
Michel Dänzer <mdaenzer@redhat.com>
-
-
-
-
One minute is admittedly arbitrary, but again, pretty sure this never gets set on the command line in practice.
-
-
-
I strongly suspect these never get used in the wild, and it's not an especially useful thing to do in any case.
-
There's not any configuration knobs for this so there's no real reason to leave them in a configgy header.
-
Again, we're setting this at configure time now.
-
We're always setting this in the appropriate blah-config.h now.
-
-
-
-
- 29 Oct, 2019 2 commits
-
-
Populate outout possible_crtcs as the union of possible_crtcs from the encoders rather than the intersection. Otherwise we're easily left with possible_crtcs==0 when all the possible encoders have non-overlapping possible_crtcs. No idea what the magic 0x7f is about, but keep it around in case it matters. Signed-off-by:
Ville Syrjälä <ville.syrjala@linux.intel.com>
-
This fixes modesetting driver build failure which can be triggered with the following configure options: $ ./configure --disable-dri --disable-dri2 --disable-dri3 --disable-config-udev --enable-xorg Bugzilla: https://bugs.gentoo.org/689768 Signed-off-by:
Alexander Tsoy <alexander@tsoy.me> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com>
-
- 26 Oct, 2019 1 commit
-
-
Jon Turney authored
Fix xquartz build after typo in 3c78d637 ("global: Remove BUILD_DATE and BUILD_TIME")
-
- 23 Oct, 2019 1 commit
-
-
Keith Packard authored
This seems like a simple typo to me; thanks to C it isn't caught by the compiler. Signed-off-by:
Keith Packard <keithp@keithp.com>
-
- 16 Oct, 2019 1 commit
-
-
If `need_rotate` is TRUE, we should check for the right rotate.
-
- 15 Oct, 2019 8 commits
-
-
Adam Jackson authored
Delightfully this is undefined even though CARD16 is an "unsigned" type, because it's an unsigned short, which C promotes to signed int because everything is stupid.
-
Adam Jackson authored
Again, memset(0, ...) is undefined.
-
Adam Jackson authored
If we don't have any recording contexts just skip all this. Note this also skips a pointless trip through malloc(0)/free.
-
Adam Jackson authored
The first time we get here, eventQueue->events is NULL.
-
Adam Jackson authored
The hits keep coming.
-
Adam Jackson authored
Again, we need all of the bits of an unsigned int to make this work.
-
Adam Jackson authored
The masks we end up building will occupy all 32 bits of an unsigned int, which means we had better build the shifts out of unsigned ints, because left-shifting a signed int all the way into the sign bit is undefined.
-
Adam Jackson authored
When we set these up initially, no subsystems have allocated any privates yet, so the storage address will be null, and memset(NULL, ...) is undefined.
-
- 14 Oct, 2019 1 commit
-
-
Caused assertion failures / crashes with Xorg. Closes: xorg/xserver#916
-
- 12 Oct, 2019 5 commits
-
-
Hans de Goede authored
Apps using randr to change the resolution when going fullscreen, in combination with _NET_WM_STATE_FULLSCREEN to tell the window-manager (WM) to make their window fullscreen, expect the WM to give the fullscreen window the size of the emulated resolution as would happen when run under Xorg (*). We need the WM to emulate this behavior for these apps to work correctly, with Xwaylands resolution change emulation. For the WM to emulate this, it needs to know about the emulated resolution for the Windows owning client for each monitor. This commit adds a _XWAYLAND_RANDR_EMU_MONITOR_RECTS property, which contains 4 Cardinals (32 bit integers) per monitor with resolution emulation info. Window-managers can use this to get the emulated resolution for the client and size the window correctly. *) Since under Xorg the resolution will actually be changed and after that going fullscreen through NET_WM_STATE_FULLSCREEN will size the window to be equal to the new resolution. Reviewed-by:
Olivier Fourdan <ofourdan@redhat.com> Acked-by:
Michel Dänzer <mdaenzer@redhat.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
Hans de Goede authored
Games based on the allegro gaming library or on ClanLib-1.0 do not size their window to match the fullscreen resolution, instead they use a window covering the entire screen, drawing only the fullscreen resolution part of it. This commit adds a check for these games, so that we correctly apply a viewport to them making fullscreen work properly for these games under Xwayland. Reviewed-by:
Olivier Fourdan <ofourdan@redhat.com> Acked-by:
Michel Dänzer <mdaenzer@redhat.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
Hans de Goede authored
Add support for fake mode changes using viewport, for apps which want to change the resolution when going fullscreen. Reviewed-by:
Olivier Fourdan <ofourdan@redhat.com> Acked-by:
Michel Dänzer <mdaenzer@redhat.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
Hans de Goede authored
crtc->mode reflects the mode set through the xrandr extension, once we add support for also changing the mode through the vidmode extension this will no longer correctly reflect the emulated resolution. Add a new xwlVidModeGetCurrentRRMode helper which determines the mode by looking at the emulated_mode instead. Likewise add a xwlVidModeGetRRMode helper and use that in xwlVidModeCheckModeForMonitor/xwlVidModeCheckModeForDriver to allow any mode listed in the randr_output's mode list. This is a preparation patch for adding emulated mode/resolution change support to Xwayland's XF86 vidmode extension emulation. Reviewed-by:
Olivier Fourdan <ofourdan@redhat.com> Acked-by:
Michel Dänzer <mdaenzer@redhat.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-
Hans de Goede authored
This is a preparation patch for adding emulated mode/resolution change support to Xwayland's XF86 vidmode extension emulation, using the Wayland viewport extension. Reviewed-by:
Olivier Fourdan <ofourdan@redhat.com> Acked-by:
Michel Dänzer <mdaenzer@redhat.com> Signed-off-by:
Hans de Goede <hdegoede@redhat.com>
-