Commit 239ebdc9 authored by Val Packett's avatar Val Packett Committed by Olivier Fourdan
Browse files

xwayland: use drmGetNodeTypeFromFd for checking if a node is a render one

Major/minor numbers are a.. major (ha) source of pain in FreeBSD porting.
In this case, Xwayland was thinking that /dev/dri/card0 is already a render node,
because the st_rdev on FreeBSD was passing the Linux-style check,
and because of the assumption, acceleration would fail because
various ioctls like AMDGPU_INFO would be denied on the non-render node.

Switch to libdrm's function that already works correctly on all platforms.

Signed-off-by: Val Packett's avatarGreg V <>
Reviewed-by: Emmanuel Vadot's avatarEmmanuel Vadot <>
parent add3df20
Pipeline #204133 passed with stages
in 4 minutes and 23 seconds
......@@ -117,21 +117,6 @@ wl_drm_format_for_depth(int depth)
static char
is_fd_render_node(int fd)
struct stat render;
if (fstat(fd, &render))
return 0;
if (!S_ISCHR(render.st_mode))
return 0;
if (render.st_rdev & 0x80)
return 1;
return 0;
static char
is_device_path_render_node (const char *device_path)
......@@ -142,7 +127,7 @@ is_device_path_render_node (const char *device_path)
if (fd < 0)
return 0;
is_render_node = is_fd_render_node(fd);
is_render_node = (drmGetNodeTypeFromFd(fd) == DRM_NODE_RENDER);
return is_render_node;
......@@ -782,7 +767,7 @@ xwl_drm_handle_device(void *data, struct wl_drm *drm, const char *device)
if (is_fd_render_node(xwl_gbm->drm_fd)) {
if (drmGetNodeTypeFromFd(xwl_gbm->drm_fd) == DRM_NODE_RENDER) {
xwl_gbm->fd_render_node = 1;
} else {
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment