Thanks! For information, I have uploaded the updated patch to Ubuntu 22.10 (and will SRU it to 22.04 in due course): https://launchpad.net/ubuntu/+source/xdg-utils/1.1.3-4.1ubuntu3.
When testing this on Ubuntu 22.04 in the context of https://bugs.launchpad.net/ubuntu/+source/xdg-utils/+bug/1970594, I'm observing this:
$ xdg-settings check default-web-browser firefox.desktop
/usr/bin/xdg-settings: 734: [: x!: unexpected operator
yes
So the output is as expected, but there is an "unexpected operator" error on stderr.
Olivier (f80879c0) at 05 Aug 15:21
Sorry about the delay. I rebased on the latest main and reformatted the commit message per your request, I hope this is good enough (I'm happy to reformat again if it isn't).
Olivier (f80879c0) at 05 Aug 15:10
cursor: Try to fall back to a default xcursor theme first
... and 32 more commits
Olivier (0626a18d) at 05 Aug 14:55
cursor: Try to fall back to a default xcursor theme first
I suppose the caller (in my case GTK) could perform the fallback, if the name of the theme returned by wl_cursor_theme_load(…)
is "default" (meaning that the default hardcoded wayland cursor theme has been returned).
I'd find it more (API) user-friendly if wayland did the fallback though, I feel like this is a sensible default. This patch will only load a different cursor theme if there's one called "default", otherwise the current behaviour is unchanged.
And the implementation of xcursor_load_theme(…)
which does
if (!theme)
theme = "default";
seems to have been written for this very use case.
The use case is systems where for some reason the current xcursor theme cannot be accessed. Before falling back to wayland's default cursor theme, it is worth trying the xcursor theme called "default", which hopefully looks better than the former.
Snap applications running on Wayland can access a well-known subset of icon and cursor themes (through the gtk-common-themes content snap), but if the host system is configured to use a custom cursor theme that isn't in that subset, this results in rather ugly cursors for those snapped applications. The content snap that provides well-known themes symlinks the theme called "default" to DMZ-White. See this bug for details.
Olivier (a833bfdc) at 06 May 13:18
Try to fall back to a default xcursor theme if the requested theme ...
Olivier (b3b717f2) at 05 May 15:17
Try to fall back to a default xcursor theme if the requested theme ...