GitLab

In theory, `dispose()` functions should be idempotent and should be
prepared not to crash or cause a double-free if an unref done from
inside caused a recursive call to `dispose()` of the same object.

https://developer.gnome.org/gobject/stable/howto-gobject-destruction.html

This patch modifies the `dispose()` method to honor these constraints.

Since the double `dispose()` call won't actually occur in qtdemux (there
is no cycle detection mechanism that could invoke it to work that way),
this is more of a code cleanup than a user-facing problem fix.

Sebastian Dröge authored Jan 13, 2020 and GStreamer Marge Bot committed Jan 13, 2020

The channel position is an enum but the conversion code assumed it's a
mask. Convert accordingly.

A typo bug: | instead of & resulted in TID alwasy being set to 7
for the aggregated NALU of type 48

Sebastian Dröge authored Jan 10, 2020 and GStreamer Marge Bot committed Jan 11, 2020

By default imagefreeze will still reject new buffers after the first one
and immediately return GST_FLOW_EOS but the new allow-replace property
allows to change this.

Whenever updating the buffer we now also keep track of the configured
caps of the buffer and from the source pad task negotiate correctly
based on the potentially updated caps.

Only the very first time negotiation of a framerate with downstream is
performed, afterwards only the caps themselves apart from the framerate
are updated.

Alicia Boya García authored Jan 09, 2020 and Thibault Saunier committed Jan 09, 2020

Elements emitting frames through several srcpads should use a
flow combiner to aggregate the chain returns and therefore only return
GST_FLOW_NOT_LINKED to upstream when all the downstream pads have
received GST_FLOW_NOT_LINKED.

In addition to that, in order to handle pads being relinked downstream,
the flow combiner should be reset in response to RECONFIGURE events.
This ensures that a both srcpads process a chain operation before a
GST_FLOW_NOT_LINKED can be propagated upstream (which would usually stop
the pipeline).

Otherwise, in a configuration with two srcpads, only one linked at a
time, after the relink the element could chain data through the now
unlinked pad and the flow combiner would resolve as GST_FLOW_NOT_LINKED
(stopping the pipeline) just because the now linked pad has not been
chained yet to update the flow combiner.

This patch adds handling of RECONFIGURE events to qtdemux. Also, since
this event handling causes the flow combiner to be used from a thread
other than the qtdemux streaming thread, usages of the flow combiner
has been guarded by the object lock.

GValue might have null object.

(gst-inspect-1.0:10304): GStreamer-CRITICAL ...
    gst_object_ref_sink: assertion 'object != NULL' failed

Aaron Boxer authored Dec 24, 2019 and GStreamer Marge Bot committed Dec 30, 2019

Also, `control_url` variable has been renamed to `control_path`,
as it is actually a path.

Aaron Boxer authored Dec 06, 2019 and GStreamer Marge Bot committed Dec 30, 2019

Appending control string to end of query changes meaning of query string
Fixes #650

Eric Marks authored Dec 28, 2019 and Nicolas Dufresne committed Dec 28, 2019

Add transform filter capabilities to aasink and cacasink in the form of new elements aatv and cacatv.

Niels De Graef authored Jun 06, 2019 and Nicolas Dufresne committed Dec 28, 2019

We started depending on GLib 2.44, so we can clean up all the GObject
boilerplate macros.

Stéphane Cerveau authored Dec 18, 2019 and GStreamer Marge Bot committed Dec 20, 2019

Use helper method to get string from GValue.

Håvard Graff authored Dec 19, 2019 and GStreamer Marge Bot committed Dec 20, 2019

The key is to make sure the jitterbuffer is set to NULL *before* the
ptdemux.

The race that existed would basically happen when ptdemux had reached
READY, and the jitterbuffer would then push a buffer, triggering a new
pad with a new payloadtype being added and ghosted to the rtpbin itself.

However, the srcpad of the ptdemux would now be inactive, and all the
sticky-event pushed on it would be swallowed, not allowing any to reach
the ghost-pad. Then the buffer in-flight would come to the ghostpad,
and we would assert that a buffer arrived before the necessary
events.

By simply re-ordering the state-changes, we ensure that there will be
no buffer racing into the ptdemux while its state is being changed,
and the problem disappears completely.

Notice also that there is not point in disconnecting the signals on the
ptdemux before this point, since we need the push-thread to settle
down before we can do this in a non-racy way.

Aaron Boxer authored Sep 12, 2019 and GStreamer Marge Bot committed Dec 19, 2019

Not setting DISCONT avoids a noticable delay when seeking
with only rate changing, in the same direction as current
rate.

Olivier Crête authored Dec 10, 2019 and GStreamer Marge Bot committed Dec 18, 2019

GTimeVal won't work past 2038

Sebastian Dröge authored Dec 18, 2019 and GStreamer Marge Bot committed Dec 18, 2019

avidemux already handles this correctly.

Sebastian Dröge authored Dec 16, 2019 and GStreamer Marge Bot committed Dec 18, 2019

avidemux already handles this.

Receiving a pixel-aspect-ratio should trigger a caps change, but not
replace the existing video codec tag

Otherwise is it possible to get a crash in gst_rtspsrc_set_parameter.

Sebastian Dröge authored Dec 12, 2019 and GStreamer Marge Bot committed Dec 13, 2019

Applications might handle locations and generally configuration of the
sink by themselves instead of having splitmuxsink set the location on
the sink. Nonetheless it makes sense to increment the fragment_id that
is passed to the signal so that applications know which fragment is
requested.

This avoids creating a timestamp regression during a stream.

gstreamer/gst-plugins-good!429

Mathieu Duponchelle authored Dec 11, 2019 and GStreamer Marge Bot committed Dec 11, 2019

The logic is taken straight from matroskademux, see
77403d0a

gmtime on *nix is not thread-safe.

Stéphane Cerveau authored Dec 05, 2019 and Olivier Crête committed Dec 05, 2019

Allow to change the fragment-id start index.

Philipp Zabel authored Dec 03, 2019 and GStreamer Marge Bot committed Dec 04, 2019

If Mesa is built without X11 headers, building against Mesa EGL headers
requires a dependency on egl.pc, to define MESA_EGL_NO_X11_HEADERS.
This fixes a build error when compiling ext/qt/gstqtglutility.cc:

  In file included from /usr/include/EGL/egl.h:39,
                   from /usr/include/gstreamer-1.0/gst/gl/egl/gstegl.h:44,
                   from ../gst-plugins-good-1.16.1/ext/qt/gstqtglutility.cc:43:
  /usr/include/EGL/eglplatform.h:124:10: fatal error: X11/Xlib.h: No such file or directory

Tim-Philipp Müller authored Dec 04, 2019 and GStreamer Marge Bot committed Dec 04, 2019

Add parsed=true to output caps, as we always output
whole frames, timestamped and all. Means also that
the output can be decoded by avdec_mjpeg wihout
plugging an extra parser (which has no rank).

In file mode, only push one onMetaData at the start of the stream.

In stream mode, always push complete onMetaData. They get replaced, not
merged.

gstreamer/gst-plugins-good!418

There's no header to rewrite, so the duration is left unused.

gstreamer/gst-plugins-good!418

This was never installed and it was only used by the uninstalled
autotools dev environment to locate the -good plugins for use
in unit tests in gstreamer modules higher up the stack.

It is no longer needed now that we no longer have an autotools build.

Håvard Graff authored Oct 10, 2017 and GStreamer Marge Bot committed Dec 02, 2019

So that "/" are correct on Windows.

Håvard Graff authored Jun 30, 2017 and Håvard Graff committed Dec 02, 2019

That way we get some of the meta -> rtp-extension goodies.

Seungha Yang authored Nov 29, 2019 and Tim-Philipp Müller committed Nov 29, 2019

VPX_IMG_FMT_I444 pixel format with sRGB colorspace means
GBR data.

Fixes: gstreamer/gst-plugins-good#651

...or it will segfault from time to time...

Add a property that makes it possible for an application to set the
DateUTC header field in matroska files. This is useful for live feeds,
where the DateUTC header can be set to a UTC timestamp, matching the
beginning of the file.

Needs gstreamer!323

Fixes gstreamer/gst-plugins-good#481