Commit 590e20cb authored by Vincent Penquerc'h's avatar Vincent Penquerc'h

matroskamux: do not use uinitialized clut on error

If we're missing part of the clut, do not try to use it. It seems
very likely the break was meant to break out of the switch rather
than from the loop.

Coverity 1139878
parent d917c940
......@@ -879,7 +879,7 @@ gst_matroska_mux_handle_sink_event (GstCollectPads * pads,
if (!gst_structure_get_int (structure, name, &value)) {
GST_ERROR_OBJECT (mux, "dvd-spu-clut-change event did not "
"contain %s field", name);
break;
goto break_hard;
}
clut[i] = value;
}
......@@ -893,6 +893,7 @@ gst_matroska_mux_handle_sink_event (GstCollectPads * pads,
break;
}
break_hard:
if (event != NULL)
return gst_collect_pads_event_default (pads, data, event, FALSE);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment