Commit fb274e89 authored by Martin Peres's avatar Martin Peres
Browse files

initscript/containers: try one more time after clearing the cache

parent f8e42140
......@@ -241,7 +241,7 @@ function create_container {
# Podman is not super good at explaining what went wrong when creating a
# container, so just try multiple times, each time increasing the size of
# the hammer!
for i in 0 1 2 3; do
for i in 0 1 2 3 4; do
  • What is happening here in the wild then? Just failing with no error message?

  • Not sure I understand your sentence :)

  • It's worrying there's this uncertainty in container creation, I was curious why we need the retries. Would be a nasty test failure if we ran out of retries at this point.

  • That was just defensive coding here. I never experienced the issue. It turns out Podman already retries 3 times to connect, so I guess we could just reduce this to 2 trials: once with the cache, and once without.

  • Great, that sounds like plenty then :)

Please register or sign in to reply
# Set up the wanted container
container_id=`eval "podman create --rm --privileged --network=host --runtime /bin/crun-no-pivot $@"` \
&& podman init "$container_id" && return 0
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment