Skip to content

Action cleanup

Rylie Pavlik requested to merge rpavlik/monado:action-cleanup into main

For some reason, rpavlik/monado@c594282d breaks the following conformance test.

../src/conformance/conformance_test/test_actions.cpp:1532
...............................................................................
../src/conformance/conformance_test/test_actions.cpp:1633: FAILED:
  REQUIRE( xrSyncActions(compositionHelper.GetSession(), &syncInfo) == XR_ERROR_PATH_UNSUPPORTED )
with expansion:
  XR_SUCCESS == XR_ERROR_PATH_UNSUPPORTED
with messages:
  Basic usage
  Left hand
  Right hand
  both synchronized
  No subaction path
  Subaction path used but not declared

Never mind that I put an explicit check for this condition ahead now...

UPDATE

OK, so the problem was the accumulation of select_whatever all into select_any.

However, now we have this failure:

-------------------------------------------------------------------------------
State query functions interactive
-------------------------------------------------------------------------------
../src/conformance/conformance_test/test_actions.cpp:1663
...............................................................................
../src/conformance/conformance_test/test_actions.cpp:2480: FAILED:
  REQUIRE( floatState.currentState == Approx(0.0f).margin(cLargeEpsilon) )
with expansion:
  0.26667f == Approx( 0.0 )
with messages:
  Check controller input values
  Haptics state query
  Action value coercion
  Boolean->Float
  Float->Boolean
  1 assertion(s) failed

which I thought we had completely finished by now... and it bisects to this commit which makes no sense, unless it's just a transient issue/race condition? !458 (17709e28)

Edited by Rylie Pavlik

Merge request reports