Skip to content
Snippets Groups Projects

Initial 3dof with DepthAI

Merged Moshi Turner requested to merge slitcch/monado:mt/depthai-3dof-may9 into main
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • It looks good to me, there are a couple of dangling comments and mock variable/field names I think, but you'll probably remove those later.

      The overall separation of the data source (frame server) and the device looks good.

      It's good that you got 3dof working. I would be super careful with the timestamp stuff though, those could easily break a future SLAM integration.

      In particular:

      1. Are you sure depthai gives you timestamps in "system clock"? i.e., a hardware timestamp that is corrected taking into consideration a good (and dynamic) estimate of the USB RTT? It looks like so because of the dai_ts_to_monado_ts function but it's worth to double check.
      2. Do you know if depthai frame and IMU timestamps are properly synced? If you print the timestamps of both frames and IMU samples as soon as you receive them you should see frames that are about 5ms-10ms in the past, more than that could point to an issue in the sync mechanism.
    • Author Developer
      1. Yes, it's in system time. However I have no clue how they're managing USB latency, so it might be slightly wrong.
      2. I have no idea if they're properly synced, one can hope ;) I'll try that before I get too far into SLAM stuff
    • Please register or sign in to reply
  • Moshi Turner added 5 commits

    added 5 commits

    • f4404a3b - d/dai: We didn't need this calibration struct for anything
    • 5a0805f4 - d/dai: Add initial IMU support
    • 4cd67608 - inc/xrt, steamvr_drv: add DepthAI device type
    • 9a3bb793 - d/dai: Add little xrt_device implementation for head tracking
    • ae715725 - targets: Add DepthAI head tracker

    Compare with previous version

  • Moshi Turner added 5 commits

    added 5 commits

    • af5516f4 - d/dai: We didn't need this calibration struct for anything
    • 5ba7ae3c - d/dai: Add initial IMU support
    • c7cb763b - inc/xrt, steamvr_drv: add DepthAI device type
    • e8776fd7 - d/dai: Add little xrt_device implementation for head tracking
    • ec191bd9 - targets: Add DepthAI head tracker

    Compare with previous version

  • Looks good, thanks!

  • merged

  • Please register or sign in to reply
    Loading