Skip to content

xrt: Revert xrt_view::display::{w|h}_pixels changes

James Hogan requested to merge jameshogan/monado:wh_pixels into main

On latest main branch, dummy device, I started getting this error:

XR_ERROR_VALIDATION_FAILURE: xrCreateSwapchain(createInfo->width == 0) must be non-zero

which I tracked down to a recommended image size of 0*0 from OpenXR.

This was bisected to commit 749723f0 ("xrt: Remove xrt_view::display::{w|h}_meters") which (as far as I can tell from my unfamiliar eye) accidentally removed some references to {w|h}_pixels as well as {w|h}_meters.

Revert those changes without reverting the rest of the commit.

bisect log:

git bisect start
# good: [ad7b5cb786369014059172623736ad8763200f13] gitignore: update
git bisect good ad7b5cb786369014059172623736ad8763200f13
# bad: [4e4e6708bcfad5ae8e7dbde8caf778b6fffc7a52] Revert "d/survive: ajust timestamp from button event"
git bisect bad 4e4e6708bcfad5ae8e7dbde8caf778b6fffc7a52
# good: [4957f6577f2db2c94fdbdbd35e120bae6e5a210e] st/p: Migrate num_ to _count
git bisect good 4957f6577f2db2c94fdbdbd35e120bae6e5a210e
# good: [07bd61493015a6921c3091f72c0445f2420fe827] t/file: Extend calibration save/load interfaces with new v2 format
git bisect good 07bd61493015a6921c3091f72c0445f2420fe827
# good: [2af3798e4445eb77427032f95a2ab801422bce4e] a/vk: Fix typo in physical device feature chain
git bisect good 2af3798e4445eb77427032f95a2ab801422bce4e
# bad: [2d48a9bca22df23104d9a6963c1e193248f4e779] d/wmr: WMR Controller (BT) 3DoF working, based on gyro and accel.
git bisect bad 2d48a9bca22df23104d9a6963c1e193248f4e779
# good: [ef4550c2680935a66caffb08956a6d12e3d050b4] a/math: Add a "get latest" to relation history as well.
git bisect good ef4550c2680935a66caffb08956a6d12e3d050b4
# bad: [749723f0bab984cb9d06ab84dc61453864600020] xrt: Remove xrt_view::display::{w|h}_meters
git bisect bad 749723f0bab984cb9d06ab84dc61453864600020
# good: [5b1c60eeb00567568fe226a59779097400d49a9f] xrt: Add unique_ptr typedef for xrt_device
git bisect good 5b1c60eeb00567568fe226a59779097400d49a9f
# good: [59a09abf6a6ff2db3e4231f1f8681bc5a86ee416] d/dai: Document work around
git bisect good 59a09abf6a6ff2db3e4231f1f8681bc5a86ee416
# first bad commit: [749723f0bab984cb9d06ab84dc61453864600020] xrt: Remove xrt_view::display::{w|h}_meters

Merge request reports