d/dd: Massive tidy and a bit of refactoring

7 jobs for pb_daydreamcontroller in 2 minutes and 13 seconds (queued for 2 seconds)
latest
Status Job ID Name Coverage
  Container Prep
passed #1756369
arch:container_prep

00:00:24

passed #1756368
debian:container_prep

00:00:22

 
  Build
failed #1756372
arch:build-cmake

00:01:26

failed #1756374
arch:build-meson

00:00:42

failed #1756371
debian:build-cmake

00:00:30

failed #1756373
debian:build-meson

00:01:48

failed #1756370
format-and-spellcheck

00:00:13

 
Name Stage Failure
failed
debian:build-cmake Build
[35/125] Building CXX object src/xrt/auxiliary/CMakeFiles/aux_tracking.dir/tracking/t_debug_hsv_filter.cpp.o
[36/125] Building CXX object src/xrt/auxiliary/CMakeFiles/aux_tracking.dir/tracking/t_file.cpp.o
[37/125] Building CXX object src/xrt/auxiliary/CMakeFiles/aux_tracking.dir/tracking/t_tracker_psmv.cpp.o
[38/125] Building CXX object src/xrt/auxiliary/CMakeFiles/aux_tracking.dir/tracking/t_calibration.cpp.o
[39/125] Building CXX object src/xrt/auxiliary/CMakeFiles/aux_math.dir/math/m_base.cpp.o
[40/125] Building CXX object src/xrt/auxiliary/CMakeFiles/aux_tracking.dir/tracking/t_imu.cpp.o
[41/125] Building CXX object src/xrt/auxiliary/CMakeFiles/aux_tracking.dir/tracking/t_kalman.cpp.o
ninja: build stopped: subcommand failed.
ERROR: Job failed: exit code 1
failed
format-and-spellcheck Build
+	    ble, pdaydream->print_spew, pdaydream->print_debug);

return &dd->base;
}
---------------------------------------
Uploading artifacts...
patches/: found 2 matching files
Uploading artifacts to coordinator... ok
id=1756370 responseStatus=201 Created token=cyZrg3fW
ERROR: Job failed: exit code 1
failed
arch:build-meson Build
[129/149] Compiling C++ object 'src/xrt/auxiliary/f5ab5bb@@aux_tracking@sta/tracking_t_debug_hsv_filter.cpp.o'.
[130/149] Compiling C++ object 'src/xrt/auxiliary/f5ab5bb@@aux_tracking@sta/tracking_t_debug_hsv_picker.cpp.o'.
[131/149] Compiling C++ object 'src/xrt/auxiliary/f5ab5bb@@aux_tracking@sta/tracking_t_tracker_psmv.cpp.o'.
[132/149] Compiling C++ object 'src/xrt/auxiliary/f5ab5bb@@aux_math@sta/math_m_base.cpp.o'.
[133/149] Compiling C++ object 'src/xrt/auxiliary/f5ab5bb@@aux_tracking@sta/tracking_t_calibration.cpp.o'.
[134/149] Compiling C++ object 'src/xrt/auxiliary/f5ab5bb@@aux_tracking@sta/tracking_t_imu.cpp.o'.
[135/149] Compiling C++ object 'src/xrt/auxiliary/f5ab5bb@@aux_tracking@sta/tracking_t_kalman.cpp.o'.
ninja: build stopped: subcommand failed.
ERROR: Job failed: exit code 1
failed
arch:build-cmake Build
/usr/sbin/ld: src/xrt/drivers/CMakeFiles/drv_daydream.dir/daydream/daydream_device.c.o: in function `daydream_device_destroy':
daydream_device.c:(.text+0x1004): undefined reference to `daydream_device'
/usr/sbin/ld: src/xrt/drivers/CMakeFiles/drv_daydream.dir/daydream/daydream_device.c.o: in function `daydream_device_update_inputs':
daydream_device.c:(.text+0x10a8): undefined reference to `daydream_device'
/usr/sbin/ld: src/xrt/drivers/CMakeFiles/drv_daydream.dir/daydream/daydream_device.c.o: in function `daydream_device_get_tracked_pose':
daydream_device.c:(.text+0x1208): undefined reference to `daydream_device'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
ERROR: Job failed: exit code 1
failed
debian:build-meson Build
  Ignoring the command for directory /builds/monado/monado/src/xrt/compositor/

error: file `/builds/monado/monado/build/src/xrt/compositor/8e991c0@@comp@sta/main_comp_compositor.c.o.d' not found
warning: Included by graph for 'u_debug.h' not generated, too many nodes. Consider increasing DOT_GRAPH_MAX_NODES.
warning: Included by graph for 'u_misc.h' not generated, too many nodes. Consider increasing DOT_GRAPH_MAX_NODES.
[129/140] Compiling C++ object 'src/xrt/auxiliary/f5ab5bb@@aux_tracking@sta/tracking_t_imu.cpp.o'.
[130/140] Compiling C++ object 'src/xrt/auxiliary/f5ab5bb@@aux_tracking@sta/tracking_t_kalman.cpp.o'.
ninja: build stopped: subcommand failed.
ERROR: Job failed: exit code 1