Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • M Monado
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 41
    • Merge requests 41
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Monado
  • Monado
  • Merge requests
  • !155

oxr: check input type in oxr_swapchain_gl_enumerate_images

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Simon Ser requested to merge emersion/monado:enumerate-images-check-type into master Oct 30, 2019
  • Overview 7
  • Commits 1
  • Pipelines 5
  • Changes 1

Don't blindly cast the input struct to XrSwapchainImageOpenGLKHR, check that the type is XR_TYPE_SWAPCHAIN_IMAGE_OPENGL_KHR.

I'm not sure we should use OXR_GET_INPUT_FROM_CHAIN here. If not, should I just replace it with a type check and a cast?

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: enumerate-images-check-type