Logic error in PSVR tracker finding triangles?
Specifically looking at the loop here: https://gitlab.freedesktop.org/monado/monado/-/blob/master/src/xrt/auxiliary/tracking/t_tracker_psvr.cpp#L674-685
It looks like it's supposed to find the match (starting with the third) whose model vertex is furthest from the model vertex of the first. However, highest_length
stays at 0.0f
the whole time and is never updated, meaning it will always return the last item.
Did I guess what that code is supposed to do, correctly? It's always had this bug as far as I can see in the git history - presumably it once didn't have this but that got squashed away - but I'd like to fix it, and if my guess is right, I do have a fix here for it.