1. 11 Jan, 2022 1 commit
  2. 06 Jan, 2022 1 commit
    • Antonio Ospite's avatar
      c/client: make sure layer_commit passes complete frames in comp_gl_client · 2b456da5
      Antonio Ospite authored and Jakob Bornecrantz's avatar Jakob Bornecrantz committed
      Make sure `layer_commit` passes on complete frames in `comp_gl_client.c`
      even when EGL_ANDROID_native_fence_sync is not available.
      
      The `insert_fence` function defined in `comp_egl_client.c` and passed as
      argument to `comp_egl_client::client_gl_compositor_init` is only setting
      up a proper fence when EGL_ANDROID_native_fence_sync is available,
      resulting in a no-op otherwise.
      
      However the fact that the insert_fence function is still valid results
      in the `glFlush` workaround from
      `comp_gl_client::client_gl_compositor_layer_commit` not kicking in.
      
      To fix this define a NULL `insert_fence` function when
      EGL_ANDROID_native_fence_sync is not available, and while at it turn the
      `glFlush` workaround into a `glFinish` for extra safety.
      
      This ensures that frames are always complete after
      `client_gl_compositor_layer_commit` has been called.
      2b456da5
  3. 05 Jan, 2022 8 commits
  4. 04 Jan, 2022 5 commits
  5. 24 Dec, 2021 1 commit
  6. 22 Dec, 2021 1 commit
  7. 21 Dec, 2021 9 commits
  8. 20 Dec, 2021 2 commits
  9. 17 Dec, 2021 1 commit
  10. 14 Dec, 2021 7 commits
    • Moses Turner's avatar
      meson: use cjson_include with depthai driver · a19f1317
      Moses Turner authored and Moses Turner's avatar Moses Turner committed
      a19f1317
    • Christoph Haag's avatar
      meson: Include eigen as system library on recent meson · ceefaaf5
      Christoph Haag authored
      Avoids warnings in eigen headers:
      
      In file included from /usr/include/eigen3/Eigen/Core:341,
                       from ../src/xrt/auxiliary/tracking/t_lowpass_vector.hpp:18,
                       from ../src/xrt/auxiliary/tracking/t_imu_fusion.hpp:17,
                       from ../src/xrt/auxiliary/tracking/t_imu.cpp:12:
      /usr/include/eigen3/Eigen/src/Core/products/TriangularMatrixVector.h: In function ‘static void Eigen::internal::trmv_selector<Mode, 1>::run(const Lhs&, const Rhs&, Dest&, const typename Dest::Scalar&) [with Lhs = Eigen::Transpose<const Eigen::Block<const Eigen::Block<Eigen::Matrix<double, 3, 2, 0, 3, 2>, -1, -1, false>, -1, -1, false> >; Rhs = Eigen::Transpose<const Eigen::CwiseBinaryOp<Eigen::internal::scalar_product_op<double, double>, const Eigen::CwiseNullaryOp<Eigen::internal::scalar_constant_op<double>, const Eigen::Matrix<double, 1, -1, 1, 1, 3> >, const Eigen::Transpose<const Eigen::Block<const Eigen::Block<const Eigen::Block<Eigen::Matrix<double, 3, 2, 0, 3, 2>, -1, -1, false>, -1, 1, true>, -1, 1, false> > > >; Dest = Eigen::Transpose<Eigen::Block<Eigen::Block<Eigen::Matrix<double, -1, -1, 1, -1, -1>, 1, -1, true>, 1, -1, false> >; int Mode = 6]’:
      /usr/include/eigen3/Eigen/src/Core/products/TriangularMatrixVector.h:332:12: warning: ‘result’ may be used uninitialized [-Wmaybe-uninitialized]
        327 |     internal::triangular_matrix_vector_product
            |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        328 |       <Index,Mode,
            |       ~~~~~~~~~~~~
        329 |        LhsScalar, LhsBlasTraits::NeedToConjugate,
            |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        330 |        RhsScalar, RhsBlasTraits::NeedToConjugate,
            |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        331 |        RowMajor>
            |        ~~~~~~~~~
        332 |       ::run(actualLhs.rows(),actualLhs.cols(),
            |       ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        333 |             actualLhs.data(),actualLhs.outerStride(),
            |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        334 |             actualRhsPtr,1,
            |             ~~~~~~~~~~~~~~~
        335 |             dest.data(),dest.innerStride(),
            |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        336 |             actualAlpha);
            |             ~~~~~~~~~~~~
      /usr/include/eigen3/Eigen/src/Core/products/TriangularMatrixVector.h:105:24: note: by argument 5 of type ‘const double*’ to ‘static void Eigen::internal::triangular_matrix_vector_product<Index, Mode, LhsScalar, ConjLhs, RhsScalar, ConjRhs, 1, Version>::run(Index, Index, const LhsScalar*, Index, const RhsScalar*, Index, Eigen::internal::triangular_matrix_vector_product<Index, Mode, LhsScalar, ConjLhs, RhsScalar, ConjRhs, 1, Version>::ResScalar*, Index, const ResScalar&) [with Index = long int; int Mode = 6; LhsScalar = double; bool ConjLhs = false; RhsScalar = double; bool ConjRhs = false; int Version = 0]’ declared here
        105 | EIGEN_DONT_INLINE void triangular_matrix_vector_product<Index,Mode,LhsScalar,ConjLhs,RhsScalar,ConjRhs,RowMajor,Version>
            |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ceefaaf5
    • Christoph Haag's avatar
      d/ht_ctrl_emu: work around truncation warning · b7c8a6fa
      Christoph Haag authored
      ../src/xrt/drivers/ht_ctrl_emu/ht_ctrl_emu.cpp: In function ‘int cemu_devices_create(xrt_device*, xrt_device*, xrt_device**)’:
      ../src/xrt/drivers/ht_ctrl_emu/ht_ctrl_emu.cpp:439:102: warning: ‘ Left Hand’ directive output may be truncated writing 10 bytes into a region of size between 1 and 256 [-Wformat-truncation=]
        439 |                 int ret = snprintf(cemud[i]->base.str, XRT_DEVICE_NAME_LEN, i ? "%s Right Hand" : "%s Left Hand", hands->str);
            |                                                                                                      ^~~~~~~~~~
      ../src/xrt/drivers/ht_ctrl_emu/ht_ctrl_emu.cpp:439:35: note: ‘snprintf’ output between 11 and 266 bytes into a destination of size 256
        439 |                 int ret = snprintf(cemud[i]->base.str, XRT_DEVICE_NAME_LEN, i ? "%s Right Hand" : "%s Left Hand", hands->str);
            |                           ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../src/xrt/drivers/ht_ctrl_emu/ht_ctrl_emu.cpp:439:84: warning: ‘ Right Hand’ directive output may be truncated writing 11 bytes into a region of size between 1 and 256 [-Wformat-truncation=]
        439 |                 int ret = snprintf(cemud[i]->base.str, XRT_DEVICE_NAME_LEN, i ? "%s Right Hand" : "%s Left Hand", hands->str);
            |                                                                                    ^~~~~~~~~~~
      ../src/xrt/drivers/ht_ctrl_emu/ht_ctrl_emu.cpp:439:35: note: ‘snprintf’ output between 12 and 267 bytes into a destination of size 256
        439 |                 int ret = snprintf(cemud[i]->base.str, XRT_DEVICE_NAME_LEN, i ? "%s Right Hand" : "%s Left Hand", hands->str);
            |                           ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      b7c8a6fa
    • Christoph Haag's avatar
      d/wmr: don't print NULL value in error message · 2b101e6f
      Christoph Haag authored
      In file included from ../src/xrt/drivers/wmr/wmr_config.h:15,
                       from ../src/xrt/drivers/wmr/wmr_config.c:16:
      In function ‘wmr_config_parse_camera_config’,
          inlined from ‘wmr_config_parse_calibration’ at ../src/xrt/drivers/wmr/wmr_config.c:422:8,
          inlined from ‘wmr_hmd_config_parse’ at ../src/xrt/drivers/wmr/wmr_config.c:477:13:
      ../src/xrt/auxiliary/util/u_logging.h:84:25: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
         84 |                         u_log(__FILE__, __LINE__, __func__, level, __VA_ARGS__);                                       \
            |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../src/xrt/auxiliary/util/u_logging.h:220:38: note: in expansion of macro ‘U_LOG_IFL’
        220 | #define U_LOG_IFL_E(cond_level, ...) U_LOG_IFL(U_LOGGING_ERROR, cond_level, __VA_ARGS__)
            |                                      ^~~~~~~~~
      ../src/xrt/drivers/wmr/wmr_config.c:22:35: note: in expansion of macro ‘U_LOG_IFL_E’
         22 | #define WMR_ERROR(log_level, ...) U_LOG_IFL_E(log_level, __VA_ARGS__)
            |                                   ^~~~~~~~~~~
      ../src/xrt/drivers/wmr/wmr_config.c:267:17: note: in expansion of macro ‘WMR_ERROR’
        267 |                 WMR_ERROR(log_level, "Invalid camera calibration block %d - unknown camera purpose %s", c->n_cameras,
            |                 ^~~~~~~~~
      ../src/xrt/drivers/wmr/wmr_config.c: In function ‘wmr_hmd_config_parse’:
      ../src/xrt/drivers/wmr/wmr_config.c:267:100: note: format string is defined here
        267 |                 WMR_ERROR(log_level, "Invalid camera calibration block %d - unknown camera purpose %s", c->n_cameras,
            |                                                                                                    ^~
      2b101e6f
    • Christoph Haag's avatar
      d/hdk: Remove unused variable · 42ae21d4
      Christoph Haag authored
      42ae21d4
    • Christoph Haag's avatar
      targets/steamvr: Use python stdlib to copy · d4a491ea
      Christoph Haag authored
      monado/src/xrt/targets/steamvr_drv/copy_assets.py:8: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
        from distutils.dir_util import copy_tree
      
      monado/src/xrt/targets/steamvr_drv/copy_assets.py:8: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
        from distutils.dir_util import copy_tree
      d4a491ea
    • Christoph Haag's avatar
      a/tracking: Use #pragma message instead of #warning · 8bbaf2a0
      Christoph Haag authored
      Avoids warning
      ../src/xrt/auxiliary/tracking/t_tracker_slam.cpp:66:2: warning: #warning is a GCC extension
      8bbaf2a0
  11. 13 Dec, 2021 4 commits