Commit e78e5c80 authored by Christoph Haag's avatar Christoph Haag

st/oxr: Return appropriate errors for incomplete OpenGL XLib binding

* xDisplay must be a pointer to a Display value
* glxDrawable must be a valid GLXDrawable value
* glxContext must be a valid GLXContext value

intentionally not checked:
* glxFBConfig must be a valid GLXFBConfig value
We don't care about this one for now.
parent 4c7f830e
Pipeline #77489 passed with stages
in 1 minute and 45 seconds
......@@ -535,9 +535,25 @@ oxr_verify_XrGraphicsBindingOpenGLXlibKHR(
{
if (next->type != XR_TYPE_GRAPHICS_BINDING_OPENGL_XLIB_KHR) {
return oxr_error(log, XR_ERROR_VALIDATION_FAILURE,
" Graphics binding has invalid type");
"Graphics binding has invalid type");
  • do we no longer need leading spaces in oxr_error message strings? I thought we needed it for formatting, but the error message killing hello_xr looks formatted OK. cc @wallbraker

    Edited by Ryan Pavlik
Please register or sign in to reply
}
if (next->xDisplay == NULL) {
return oxr_error(log, XR_ERROR_VALIDATION_FAILURE,
"xDisplay is NULL");
}
if (next->glxContext == NULL) {
return oxr_error(log, XR_ERROR_VALIDATION_FAILURE,
"glxContext is NULL");
}
if (next->glxDrawable == NULL) {
return oxr_error(log, XR_ERROR_VALIDATION_FAILURE,
"glxDrawable is NULL");
}
return XR_SUCCESS;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment