MM_PLUGIN_ALLOWED_SINGLE_AT in plugin no longer causes the port to get probed.
I've gone trying to get my plugin, which was working on v1.80 to v1.20. As part of the plugin filtering I only specified MM_PLUGIN_ALLOWED_SINGLE_AT
to get it to be probed via AT commands. e.g.
return MM_PLUGIN (
g_object_new (MM_TYPE_PLUGIN_MEIG,
MM_PLUGIN_NAME, MM_MODULE_NAME,
MM_PLUGIN_ALLOWED_SUBSYSTEMS, subsystems,
MM_PLUGIN_ALLOWED_DRIVERS, drivers,
MM_PLUGIN_ALLOWED_PRODUCT_IDS, product_ids,
MM_PLUGIN_ALLOWED_SINGLE_AT, TRUE,
MM_PLUGIN_CUSTOM_INIT, &custom_init,
NULL));
This uses to work on 1.80 but no longer on 1.20.
This bit of code here in mm-plugin.c seems to be the issue:
/* Build mask of flags based on plugin */
plugin_expected_flags = MM_PORT_PROBE_NONE;
if (self->priv->at)
plugin_expected_flags |= MM_PORT_PROBE_AT;
if (self->priv->qcdm || self->priv->qcdm_required)
plugin_expected_flags |= MM_PORT_PROBE_QCDM;
if (self->priv->qmi)
plugin_expected_flags |= MM_PORT_PROBE_QMI;
if (self->priv->mbim)
plugin_expected_flags |= MM_PORT_PROBE_MBIM;
why not include self->priv->single_at
in that as well ?
This forces me to include MM_PLUGIN_ALLOWED_AT
as in:
return MM_PLUGIN (
g_object_new (MM_TYPE_PLUGIN_MEIG,
MM_PLUGIN_NAME, MM_MODULE_NAME,
MM_PLUGIN_ALLOWED_SUBSYSTEMS, subsystems,
MM_PLUGIN_ALLOWED_DRIVERS, drivers,
MM_PLUGIN_ALLOWED_PRODUCT_IDS, product_ids,
MM_PLUGIN_ALLOWED_SINGLE_AT, TRUE,
MM_PLUGIN_ALLOWED_AT, TRUE,
MM_PLUGIN_CUSTOM_INIT, &custom_init,
NULL));
which seems a bit redundant.