- 27 Feb, 2021 1 commit
-
-
Pavan Holla authored
Prior to this change, hotswap was detected on the primary sim slot only. After this change, hotswap on any slot triggers reenumeration of the modem. SIM hotswap events happening on the non-active slot would also trigger a full modem reprobe. The modem may already have been connected while the SIM event happens on the secondary slot, and we force disconnection to reload the inactive SIM info. However, a user would expect feedback for their SIM action, so we need to reprobe the modem.
-
- 26 Feb, 2021 4 commits
-
-
Aleksander Morgado authored
-
Teijo Kinnunen authored
-
Teijo Kinnunen authored
The ModemManager1.Sim.PreferredNetworks property contains the preferred networks (and access technologies, if available) configured to the SIM card. This commit implements preferred networks reading with AT+CPOL.
-
Aleksander Morgado authored
g_assert() calls may be disabled, and if so, the network registration task would never get completed.
-
- 25 Feb, 2021 5 commits
-
-
Aleksander Morgado authored
Fix the 'allow roaming' setting comparison, which was breaking the whole bearer properties comparison logic, and therefore making Simple.Connect() recreate over and over the bearer with the same settings. Fixes 5629f47a
-
Yegor Yefremov authored
Use autopep8 utility to resolve issues like spaces before brackets and wrong hanging indentation. Also treat objects like boolean variables to check whether they are None or not.
-
Aleksander Morgado authored
-
Aleksander Morgado authored
There's no point in returning a list of all ports with a given name, just provide a lookup method that returns the single port with the given name.
-
Aleksander Morgado authored
Instead of creating new clients internally whenever we need them, just make sure each MMKernelDeviceUdev object keeps a full reference to the GUdevClient that generated all GUdevDevices.
-
- 24 Feb, 2021 3 commits
-
-
Aleksander Morgado authored
We already have methods to query for interface specific attributes like class/subclass/protocol, so add a new one for the interface number, and make sure we use ATTRS{bInterfaceNumber} to load it always, instead of assuming the ID_USB_INTERFACE_NUM property is set.
-
Yegor Yefremov authored
Move the code into the main() routine.
-
Aleksander Morgado authored
-
- 23 Feb, 2021 27 commits
-
-
Aleksander Morgado authored
The only purpose of this is to log what we found, nothing else, as a quick way to detect platform support for the charsets we need.
-
Aleksander Morgado authored
-
Aleksander Morgado authored
No longer used, replaced by the new common conversion methods.
-
Aleksander Morgado authored
These methods worked in a very strict way for some encodings, and in a very very loose way for others. E.g. when converting from hex-encoded UCS-2, we would attempt to convert as much text as we could even if the input string was truly not even close to UCS-2. This kind of "do our best" could make sense when processing e.g. the operator name reported by the modem, as that is some string to show to the user and there may be no strict requirement to have it perfectly fine. But the kind of loose comparison done for UCS-2 doesn't make sense e.g. when converting USSD responses or SMS messages.
-
Aleksander Morgado authored
-
Aleksander Morgado authored
Also providing support to report errors when attempting to decode the strings.
-
Aleksander Morgado authored
Instead of blindly assuming that we can take whatever string given as valid UTF-8, we'll always attempt to convert from the current modem charset into UTF-8. Before we were doing this for hex-encoded UCS2, but not for example for GSM-7. And due to the now applied GSM-7 conversion, the mf627a/mf627b +COPS parsing unit tests are updated accordingly, because when converting from an input string that contains byte 0x40 ('@' in UTF-8) as if it were GSM-7, the 0x40 is taken as character '¡', encoded as 0xc2,0xa1 in UTF-8).
-
Aleksander Morgado authored
-
Aleksander Morgado authored
The sequence of commands is exclusively used during the set current bands operation, so there is no point in storing it in the private object data.
-
Aleksander Morgado authored
-
Aleksander Morgado authored
-
Aleksander Morgado authored
-
Aleksander Morgado authored
Use the generic mm_modem_charset_bytearray_to_utf8() instead.
-
Aleksander Morgado authored
-
Aleksander Morgado authored
Use the generic mm_modem_charset_bytearray_from_utf8() instead.
-
Aleksander Morgado authored
-
Aleksander Morgado authored
The //TRANSLIT extension is not always supported by the different iconv() implementations that we may find out there, so let's completely avoid using it. For some of the charsets it actually didn't make much sense anyway, e.g. as converting to UTF-16 or UTF-8 would always be possible without requiring //TRANSLIT to take effect. The //TRANSLIT extension was also being used sometimes in the source charset identification, which was also not fully correct, as we would only expect it in the target charset identification.
-
Aleksander Morgado authored
If the conversion is not fully compatible, the user of the method needs to request transliteration enabled explicitly in order to avoid returning errors in this method.
-
Aleksander Morgado authored
Until now, this method would automatically apply transliteration; i.e. replacing characters with '?' when no direct translation was available. We can attempt to do that transliteration on strings that are not critical, e.g. the operator name reported by the network. But we should not do that on other types of strings, e.g. on SMS contents that may really have additional purposes than just being human-readable. This commit makes the transliteration option to be explicitly requested by the caller.
-
Aleksander Morgado authored
-
Aleksander Morgado authored
It makes much more sense than returning a gchar array, as gchar is signed.
-
Aleksander Morgado authored
-
Aleksander Morgado authored
Also, remove the trailing NUL byte that was appended to the output binary stream, as it's not needed in any case.
-
Aleksander Morgado authored
Optionally given explicitly, and -1 can be used to assume it's NUL-terminated.
-
Aleksander Morgado authored
This util method checks whether the input string is a valid hex string, so make sure we return a GError on failure.
-
Aleksander Morgado authored
-
Aleksander Morgado authored
There's no point in adding a quoting option to this method; if the caller needs the appended string quoted, it should quote it before passing it to this method. It was nowhere used anyway.
-