1. 28 May, 2020 1 commit
  2. 27 May, 2020 3 commits
  3. 26 May, 2020 9 commits
  4. 25 May, 2020 1 commit
  5. 22 May, 2020 1 commit
  6. 21 May, 2020 1 commit
  7. 19 May, 2020 17 commits
    • Aleksander Morgado's avatar
      cinterion,tests: avoid cast-align errors · 98fa83a6
      Aleksander Morgado authored
      We can safely cast the data in a GArray to gpointer first, and then
      to the pointer type we require.
      
        cinterion/tests/test-modem-helpers-cinterion.c: In function 'common_test_scfg':
        cinterion/tests/test-modem-helpers-cinterion.c:56:56: error: cast increases required alignment of target type [-Werror=cast-align]
             expected_bands_str = mm_common_build_bands_string ((const MMModemBand *)expected_bands->data,
                                                                ^
        cinterion/tests/test-modem-helpers-cinterion.c:58:47: error: cast increases required alignment of target type [-Werror=cast-align]
             bands_str = mm_common_build_bands_string ((const MMModemBand *)bands->data,
                                                       ^
        cinterion/tests/test-modem-helpers-cinterion.c: In function 'common_test_scfg_response':
        cinterion/tests/test-modem-helpers-cinterion.c:209:56: error: cast increases required alignment of target type [-Werror=cast-align]
             expected_bands_str = mm_common_build_bands_string ((const MMModemBand *)expected_bands->data,
                                                                ^
        cinterion/tests/test-modem-helpers-cinterion.c:211:47: error: cast increases required alignment of target type [-Werror=cast-align]
             bands_str = mm_common_build_bands_string ((const MMModemBand *)bands->data,
                                                       ^
      98fa83a6
    • Aleksander Morgado's avatar
      wavecom: avoid cast-align errors · b71ae9ce
      Aleksander Morgado authored
      We can safely cast the data in a GArray to gpointer first, and then
      to the pointer type we require.
      
        wavecom/mm-broadband-modem-wavecom.c: In function 'set_bands_3g':
        wavecom/mm-broadband-modem-wavecom.c:800:50: error: cast increases required alignment of target type [-Werror=cast-align]
             bands_string = mm_common_build_bands_string ((MMModemBand *)bands_array_final->data,
                                                          ^
        wavecom/mm-broadband-modem-wavecom.c: In function 'set_bands_2g':
        wavecom/mm-broadband-modem-wavecom.c:872:50: error: cast increases required alignment of target type [-Werror=cast-align]
             bands_string = mm_common_build_bands_string ((MMModemBand *)bands_array_final->data,
                                                          ^
      b71ae9ce
    • Aleksander Morgado's avatar
      libmm-glib,helpers: use locale-independent strtod() · 8bf13294
      Aleksander Morgado authored
      Otherwise parsing may fail, e.g. as in this unit test:
      
        # Start of smoni tests
        # DEBUG: testing SMONI response: ^SMONI: 2G,71,-61,262,02,0143,83BA,33,33,3,6,G,NOCONN
        # DEBUG: testing SMONI response: ^SMONI: 2G,SEARCH,SEARCH
        # DEBUG: testing SMONI response: ^SMONI: 2G,673,-89,262,07,4EED,A500,16,16,7,4,G,5,-107,LIMSRV
        # DEBUG: testing SMONI response: ^SMONI: 2G,673,-80,262,07,4EED,A500,35,35,7,4,G,643,4,0,-80,0,S_FR
        # DEBUG: testing SMONI response: ^SMONI: 3G,10564,296,-7.5,-79,262,02,0143,00228FF,-92,-78,NOCONN
        **
        ERROR:cinterion/tests/test-modem-helpers-cinterion.c:1036:test_smoni_response: assertion failed (fabs (ecn0 - smoni_response_tests[i].ecn0) < 0.1): (0,5 < 0,1)
        Bail out! ERROR:cinterion/tests/test-modem-helpers-cinterion.c:1036:test_smoni_response: assertion failed (fabs (ecn0 - smoni_response_tests[i].ecn0) < 0.1): (0,5 < 0,1)
        Aborted (core dumped)
      8bf13294
    • Aleksander Morgado's avatar
      58ae8f4c
    • Aleksander Morgado's avatar
      novatel-lte: use GPtrArray to build a GStrv · 9bfc8a78
      Aleksander Morgado authored
        novatel/mm-broadband-modem-novatel-lte.c: In function 'response_processor_nwmdn_ignore_at_errors':
        novatel/mm-broadband-modem-novatel-lte.c:241:19: error: cast increases required alignment of target type [-Werror=cast-align]
             own_numbers = (GStrv) g_array_free (array, FALSE);
                           ^
      9bfc8a78
    • Aleksander Morgado's avatar
      huawei,helpers: fix warnings with -Wcast-align · a2b0cee9
      Aleksander Morgado authored
        huawei/mm-modem-helpers-huawei.c: In function 'match_info_to_ip4_addr':
        huawei/mm-modem-helpers-huawei.c:193:39: error: cast increases required alignment of target type [-Werror=cast-align]
             *out_addr = GUINT32_SWAP_LE_BE (*((guint32 *) bin));
                                               ^
        /usr/include/glib-2.0/glib/gtypes.h:184:77: note: in definition of macro 'GUINT32_SWAP_LE_BE'
         #    define GUINT32_SWAP_LE_BE(val) ((guint32) __builtin_bswap32 ((gint32) (val)))
                                                                                     ^~~
      a2b0cee9
    • Aleksander Morgado's avatar
      huawei: avoid cast-align errors · bd2e6f5d
      Aleksander Morgado authored
      We can safely cast the data in a GArray to gpointer first, and then
      to the pointer type we require.
      
        huawei/mm-broadband-modem-huawei.c: In function 'set_current_bands':
        huawei/mm-broadband-modem-huawei.c:916:50: error: cast increases required alignment of target type [-Werror=cast-align]
             bands_string = mm_common_build_bands_string ((MMModemBand *)bands_array->data,
                                                          ^
      bd2e6f5d
    • Aleksander Morgado's avatar
      xmm: avoid cast-align errors · 175bedf9
      Aleksander Morgado authored
      We can safely cast the data in a GArray to gpointer first, and then
      to the pointer type we require.
      
        xmm/mm-shared-xmm.c: In function 'validate_and_build_command_set_current_bands':
        xmm/mm-shared-xmm.c:512:45: error: cast increases required alignment of target type [-Werror=cast-align]
                 str = mm_common_build_bands_string ((const MMModemBand *)unapplied_bands->data, unapplied_bands->len);
                                                     ^
      175bedf9
    • Aleksander Morgado's avatar
      ublox,helpers: avoid cast-align errors · ccf16e00
      Aleksander Morgado authored
      We can safely cast the data in a GArray to gpointer first, and then
      to the pointer type we require.
      
        ublox/mm-modem-helpers-ublox.c: In function 'parse_bands_from_string':
        ublox/mm-modem-helpers-ublox.c:1612:48: error: cast increases required alignment of target type [-Werror=cast-align]
                 tmpstr = mm_common_build_bands_string ((MMModemBand *)(bands->data), bands->len);
                                                        ^
      ccf16e00
    • Aleksander Morgado's avatar
      cinterion,helpers: avoid cast-align errors · 76d06ce6
      Aleksander Morgado authored
      We can safely cast the data in a GArray to gpointer first, and then
      to the pointer type we require.
      
        cinterion/mm-modem-helpers-cinterion.c: In function 'mm_cinterion_build_band':
        cinterion/mm-modem-helpers-cinterion.c:409:54: error: cast increases required alignment of target type [-Werror=cast-align]
                 bands_string = mm_common_build_bands_string ((MMModemBand *)bands->data, bands->len);
                                                              ^
      76d06ce6
    • Aleksander Morgado's avatar
      telit,helpers: avoid cast-align errors · b0be4e89
      Aleksander Morgado authored
      We can safely cast the data in a GArray to gpointer first, and then
      to the pointer type we require.
      
        telit/mm-modem-helpers-telit.c: In function 'mm_telit_build_bnd_request':
        telit/mm-modem-helpers-telit.c:256:55: error: cast increases required alignment of target type [-Werror=cast-align]
                     bands_str = mm_common_build_bands_string ((const MMModemBand *)(bands_array->data), bands_array->len);
                                                               ^
        telit/mm-modem-helpers-telit.c:275:55: error: cast increases required alignment of target type [-Werror=cast-align]
                     bands_str = mm_common_build_bands_string ((const MMModemBand *)(bands_array->data), bands_array->len);
                                                               ^
      b0be4e89
    • Aleksander Morgado's avatar
      plugins,tests: avoid cast-align errors · 301b6f0a
      Aleksander Morgado authored
      We can safely cast the data in a GArray to gpointer first, and then
      to the pointer type we require.
      
        tests/test-helpers.c: In function 'mm_test_helpers_compare_bands':
        tests/test-helpers.c:41:47: error: cast increases required alignment of target type [-Werror=cast-align]
             bands_str = mm_common_build_bands_string ((MMModemBand *)(bands->data), bands->len);
                                                       ^
        tests/test-helpers.c:46:56: error: cast increases required alignment of target type [-Werror=cast-align]
             expected_bands_str = mm_common_build_bands_string ((MMModemBand *)(expected_bands_array->data), expected_bands_array->len);
                                                                ^
      301b6f0a
    • Aleksander Morgado's avatar
      test-qcdm-serial-port: fix warnings with -Wsign-compare · c7dee320
      Aleksander Morgado authored
        test-qcdm-serial-port.c: In function 'wait_for_child':
        test-qcdm-serial-port.c:57:52: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
                 if (d->child && (now.tv_sec - start.tv_sec > timeout)) {
                                                            ^
      c7dee320
    • Aleksander Morgado's avatar
      iface-modem-messaging: avoid cast-align errors · 71d8bb2e
      Aleksander Morgado authored
      We can safely cast the data in a GArray to gpointer first, and then
      to the pointer type we require.
      
        mm-iface-modem-messaging.c: In function 'load_supported_storages_ready':
        mm-iface-modem-messaging.c:1154:53: error: cast increases required alignment of target type [-Werror=cast-align]
                 mem1 = mm_common_build_sms_storages_string ((MMSmsStorage *)storage_ctx->supported_mem1->data,
                                                             ^
        mm-iface-modem-messaging.c:1156:53: error: cast increases required alignment of target type [-Werror=cast-align]
                 mem2 = mm_common_build_sms_storages_string ((MMSmsStorage *)storage_ctx->supported_mem2->data,
                                                             ^
        mm-iface-modem-messaging.c:1158:53: error: cast increases required alignment of target type [-Werror=cast-align]
                 mem3 = mm_common_build_sms_storages_string ((MMSmsStorage *)storage_ctx->supported_mem3->data,
                                                             ^
      71d8bb2e
    • Aleksander Morgado's avatar
      iface-modem-location: avoid warnings with -Wsign-compare · ffbbec4a
      Aleksander Morgado authored
        mm-iface-modem-location.c: In function 'location_gps_update_nmea':
        mm-iface-modem-location.c:272:61: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
                      time (NULL) - ctx->location_gps_nmea_last_time >= mm_gdbus_modem_location_get_gps_refresh_rate (skeleton))) {
                                                                     ^~
        mm-iface-modem-location.c:282:60: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
                      time (NULL) - ctx->location_gps_raw_last_time >= mm_gdbus_modem_location_get_gps_refresh_rate (skeleton))) {
                                                                    ^~
      ffbbec4a
    • Aleksander Morgado's avatar
      iface-modem: avoid cast-align errors · 7ccec0bd
      Aleksander Morgado authored
      We can safely cast the data in a GArray to gpointer first, and then
      to the pointer type we require.
      
        mm-iface-modem.c: In function 'after_set_load_current_bands_ready':
        mm-iface-modem.c:2358:55: error: cast increases required alignment of target type [-Werror=cast-align]
                 requested_str = mm_common_build_bands_string ((MMModemBand *)requested_bands->data, requested_bands->len);
                                                               ^
        mm-iface-modem.c:2359:55: error: cast increases required alignment of target type [-Werror=cast-align]
                 current_str   = mm_common_build_bands_string ((MMModemBand *)current_bands->data, current_bands->len);
                                                               ^
        mm-iface-modem.c: In function 'validate_bands':
        mm-iface-modem.c:2474:48: error: cast increases required alignment of target type [-Werror=cast-align]
                                                        (const MMModemBand *)supported_bands_array->data,
                                                        ^
        mm-iface-modem.c: In function 'mm_iface_modem_set_current_bands':
        mm-iface-modem.c:2535:50: error: cast increases required alignment of target type [-Werror=cast-align]
             bands_string = mm_common_build_bands_string ((MMModemBand *)bands_array->data,
                                                          ^
      7ccec0bd
    • Aleksander Morgado's avatar
      modem-helpers: use GPtrArray to build a GStrv · 3476e140
      Aleksander Morgado authored
      So that we avoid errors when building on ARM due to increasing target
      type alignment.
      
        mm-modem-helpers.c: In function 'mm_3gpp_parse_cnum_exec_response':
        mm-modem-helpers.c:3206:21: error: cast increases required alignment of target type [-Werror=cast-align]
             return (array ? (GStrv) g_array_free (array, FALSE) : NULL);
                             ^
      3476e140
  8. 18 May, 2020 1 commit
    • Giacinto Cifelli's avatar
      AT modem: charset definition in init · 8e033ba3
      Giacinto Cifelli authored
      Charset definition moved from enable state machine to init state machine,
      so that the right current charset is available also during further
      initialization steps
      8e033ba3
  9. 16 May, 2020 2 commits
    • Aleksander Morgado's avatar
      port-qmi: plug memleak when explicitly releasing client · 503581a3
      Aleksander Morgado authored
        ==43111== 24 bytes in 1 blocks are definitely lost in loss record 1,999 of 5,339
        ==43111==    at 0x483BB65: calloc (vg_replace_malloc.c:762)
        ==43111==    by 0x50259D1: g_malloc0 (in /usr/lib/libglib-2.0.so.0.6400.2)
        ==43111==    by 0x22AAB8: mm_port_qmi_allocate_client (mm-port-qmi.c:201)
        ==43111==    by 0x2007F0: parent_enabling_started_ready (mm-broadband-modem-qmi.c:9114)
        ==43111==    by 0x4E68653: ??? (in /usr/lib/libgio-2.0.so.0.6400.2)
        ==43111==    by 0x4E6DA26: ??? (in /usr/lib/libgio-2.0.so.0.6400.2)
        ==43111==    by 0x1C535E: enabling_flash_done (mm-broadband-modem.c:10318)
        ==43111==    by 0x4E68653: ??? (in /usr/lib/libgio-2.0.so.0.6400.2)
        ==43111==    by 0x4E6DA26: ??? (in /usr/lib/libgio-2.0.so.0.6400.2)
        ==43111==    by 0x224F0B: flash_do (mm-port-serial.c:1776)
        ==43111==    by 0x502AC03: ??? (in /usr/lib/libglib-2.0.so.0.6400.2)
        ==43111==    by 0x502B58E: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.6400.2)
        ==43111==
      503581a3
    • Giacinto Cifelli's avatar
      fae614be
  10. 15 May, 2020 2 commits
  11. 14 May, 2020 2 commits