Fix failing assert in swapchain_base.cpp

Erroneous assert was left in swapchain_base.cpp after some refactoring
was done. This commit removes the assert and updates the CMakeLists.txt
file to turn on compiler warnings so that developers can spot these
leftover code earlier.

Change-Id: I7f4051c89a86f21f66f20b0e92f01bc101436c71
Signed-off-by: Dennis Tsiang <dennis.tsiang@arm.com>
1 job for upstream/remove-assert in 1 minute and 36 seconds (queued for 2 seconds)
Status Job ID Name Coverage
  Test
passed #5217545
build_vulkan_wsi_layer

00:01:36