1. 05 May, 2021 1 commit
    • Dennis Tsiang's avatar
      Resolve segfault in wsialloc_delete · 241e05d3
      Dennis Tsiang authored
      A segfault can occur if wsialloc_delete is called but m_wsi_allocator's
      ion field has not been allocated yet, as the function attempts to access
      the ion properties.
      This commit resolves the issue by changing m_wsi_allocator to an opaque
      struct and removing the fd property, which was not being used.
      wsialloc_new is then changed to return a pointer to the struct and
      the swapchain then carries this pointer around, which will be
      initialised to nullptr in the swapchain constructor.
      Change-Id: I202e967cff4555babf0ddcd387275b74470b09d5
      Signed-off-by: Dennis Tsiang's avatarDennis Tsiang <dennis.tsiang@arm.com>
  2. 30 Apr, 2021 1 commit
  3. 29 Apr, 2021 1 commit
  4. 23 Apr, 2021 1 commit
  5. 21 Apr, 2021 1 commit
  6. 08 Apr, 2021 1 commit
    • David Harvey-Macaulay's avatar
      Apply workaround for Wayland set_queue race · 5b6fe330
      David Harvey-Macaulay authored
      Wayland objects receive events from the server into an event queue.
      Unless specified otherwise, events from the server arrive to the event
      queue belonging to the parent object. It is beneficial for us to
      override this default queue assignment so that we receive only the
      events we are interested in.
      We currently override the default event queue assignment using
      wl_proxy_set_queue after object construction:
      struct wl_object *child_object = wl_create_object(parent_object);
      wl_proxy_set_queue((struct wl_proxy *)child_object, queue);
      There is a race condition here: events may be received into the parent's
      queue before we have a chance to perform this override. This will lead
      to hangs if we are expecting an event to arrive to our specific queue.
      To workaround this issue, we can use a wrapper object to specify the
      desired event queue at the time of object creation:
      struct wl_object *parent_wrapper = wl_proxy_create_wrapper(parent_object);
      wl_proxy_set_queue((struct wl_proxy *)parent_wrapper, queue);
      struct wl_object *child_object = wl_create_object(parent_wrapper);
      This commit applies this workaround to all object allocations whose
      intended event queues differ from the default assignment to avoid the
      aforementioned race condition.
      Change-Id: I3e6a7c679280f0d66b02ab7eab06a010e9e24b36
      Signed-off-by: David Harvey-Macaulay's avatarDavid Harvey-Macaulay <david.harvey-macaulay@arm.com>
  7. 30 Mar, 2021 1 commit
  8. 15 Mar, 2021 1 commit
    • Normunds Rieksts's avatar
      Replace swapchain roundtrip implementation in Wayland · ab41b59b
      Normunds Rieksts authored
      Replace the implementation of how the roundtrips are done in
      Wayland with one that is provided by the native Wayland client.
      Additionally, fixes a small issue present in the Wayland swapchain
      where WSI allocator would be freed by the destructor before
      wsialloc_new was called resulting in an crash where WSI allocator
      would be in an invalid state.
      Change-Id: Idfadb88078f94ff15c9f18d1809b01941f2f8548
      Signed-off-by: default avatarNormunds Rieksts <normunds.rieksts@arm.com>
  9. 04 Mar, 2021 1 commit
  10. 09 Feb, 2021 1 commit
    • Iason Paraskevopoulos's avatar
      Adds initial support for VK_KHR_wayland_surface. · 8dc4d923
      Iason Paraskevopoulos authored
      Very basic Wayland support is implemented by importing
      memory with VK_EXT_image_drm_format_modifiers.
      The current implementation requires an external system
      memory allocator. An API for this allocator is defined
      in util/wsialloc/wsialloc.h and an implementation using
      the ION memory allocator is included.
      Outstanding issues:
       * This is an initial prototype for Wayland support and
         has many outstanding TODOs which need addressing to
         properly use the Wayland protocol.
       * Using ICD Exported memory instead of a system allocator
         is not implemented.
      Wayland support is still experimental and outstanding issues
      will be fixed in future commits.
      Change-Id: I1b0d5991e15ff1cf25ebbab3392a631b021e8c17
      Signed-off-by: Rosen's avatarRosen Zhelev <rosen.zhelev@arm.com>
      Signed-off-by: Iason Paraskevopoulos's avatarIason Paraskevopoulos <iason.paraskevopoulos@arm.com>
  11. 05 Feb, 2021 1 commit
    • Joseph Jenner-Bailey's avatar
      layer: improve how layer handles Vulkan extensions · 950cdd40
      Joseph Jenner-Bailey authored
      In vkCreateInstance:
      - ppEnabledExtensionNames is checked to determine which window-system
        platforms the layer should enable support for.
      - support in the layer is always enabled if possible, even if this may
        be provided by the ICDs. Platforms not supported by the layer should
        still be correctly supported by the ICDs (untested.)
      - pApplicationInfo is changed to bump the Vulkan API version
        in order to enable instance extensions that are necessary for some
        of the platforms implemented in the layer.
      In vkCreateDevice:
      - ppEnabledExtensionNames is extended with device extensions required
        by the layer.
      - if the extensions are not supported by the physical device, the
        layer fails to initialize the device.
      Change-Id: Ibdd69fca38e7909d5b8f0ac7698805ea5f425ac6
      Signed-off-by: Joseph Jenner-Bailey's avatarJoe Jenner-Bailey <joe.jenner-bailey@arm.com>
      Signed-off-by: Matteo Franchin's avatarMatteo Franchin <matteo.franchin@arm.com>
  12. 18 Jan, 2021 1 commit
  13. 10 Dec, 2020 1 commit
    • Matteo Franchin's avatar
      Use util::allocator in swapchain object · f0b541a4
      Matteo Franchin authored
      Change util::allocator's create and destroy methods so that they can
      allocate multiple objects, in line with the allocate and deallocate
      methods of std::allocator.
      Also add documentation for util::allocator and its methods.
      Finally, use util::allocator in swapchain.cpp, rather than allocating
      memory directly via VkAllocationCallbacks.
      Change-Id: I0bc25abe3cbc3af9608218411da8d70e04dd9749
      Signed-off-by: Matteo Franchin's avatarMatteo Franchin <matteo.franchin@arm.com>
  14. 03 Dec, 2020 1 commit
  15. 30 Nov, 2020 1 commit
    • Joseph Jenner-Bailey's avatar
      Implement a vector utility that uses a custom allocator · 9585b28b
      Joseph Jenner-Bailey authored
      Add util::vector to provide functionality similar to std::vector,
      i.e. growable arrays. util::vector does its allocations via a custom
      allocator provided via VkAllocationCallbacks and provides methods to
      check whether the allocation fails, e.g. try_push_back() returns false
      when the allocation fails and replaces std::vector's push_back() method
      that would rather raise an exception to report an allocation failure.
      Note that this commit switches on exceptions in the layer by removing
      the flag -fno-exceptions.
      util::vector is also used to store swapchain images.
      Change-Id: I2bf2b24bd06e198c198c4f4aedd8f7fced96a346
      Signed-off-by: Joseph Jenner-Bailey's avatarJoe Jenner-Bailey <joe.jenner-bailey@arm.com>
      Signed-off-by: Matteo Franchin's avatarMatteo Franchin <matteo.franchin@arm.com>
  16. 26 Nov, 2020 1 commit
  17. 27 Oct, 2020 1 commit
    • Dennis Tsiang's avatar
      Fix failing assert in swapchain_base.cpp · f782eab9
      Dennis Tsiang authored
      Erroneous assert was left in swapchain_base.cpp after some refactoring
      was done. This commit removes the assert and updates the CMakeLists.txt
      file to turn on compiler warnings so that developers can spot these
      leftover code earlier.
      Change-Id: I7f4051c89a86f21f66f20b0e92f01bc101436c71
      Signed-off-by: Dennis Tsiang's avatarDennis Tsiang <dennis.tsiang@arm.com>
  18. 29 Jun, 2020 1 commit
  19. 01 May, 2020 1 commit
    • Dennis Tsiang's avatar
      Remove use of pthread_cancel in the swapchain page flip thread · 81544d04
      Dennis Tsiang authored
      The WSI layer may call pthread_cancel and kill the page flip
      thread while it's still being used in Vulkan-API calls. This can cause the
      layer to fail to clean up internal resources of the associated device,
      leading to memory leaks. To resolve this, the layer now instead checks
      if the page flip thread needs to end on every loop iteration. The
      m_page_flip_semaphore has also been changed to a timed_semaphore to avoid
      hanging indefinitely. In addition, m_page_flip_thread is now type
      std::thread, which follows the gradual move towards C++ standard code
      and moved to a private member function of the class.
      Change-Id: Iefbdd0d68e1f92fdf79bcebb7eaf33429fc61fd3
      Signed-off-by: Dennis Tsiang's avatarDennis Tsiang <dennis.tsiang@arm.com>
  20. 21 Nov, 2019 1 commit
    • Rosen's avatar
      Move WSI type specific calls · 32623418
      Rosen authored
      Move all WSI type specific calls to WSI factory methods. This
      removes headless references in layer/ and allows for simpler
      support of multiple windowing systems.
      Change-Id: I757a7a3bb4267783420b52cceb3bde8ce233297e
      Signed-off-by: Rosen's avatarRosen Zhelev <rosen.zhelev@arm.com>
  21. 30 Sep, 2019 1 commit
  22. 11 Sep, 2019 1 commit
  23. 31 May, 2019 1 commit
    • Matteo Franchin's avatar
      Initial sources for the vulkan-wsi-layer project · 9b698b4a
      Matteo Franchin authored
      This commit adds the initial sources for the vulkan-wsi-layer project:
      a Vulkan layer which implements some of the Vulkan window system
      integration extensions such as VK_KHR_swapchain.
      The layer is designed to be GPU vendor agnostic when used as part of the
      Vulkan ICD/loader architecture.
      The project currently implements support for VK_EXT_headless_surface and
      its dependencies. We hope to extend support for further platforms such
      as Wayland and direct-to-display rendering in the future.
      This initial commit collects contributions from different individuals
      employed by Arm.
      More information on the project (building instructions, how to
      contribute, etc.) can be found on the README.md file at the top of the
      project tree.
      Signed-off-by: Matteo Franchin's avatarMatteo Franchin <matteo.franchin@arm.com>