From a66c991fca85eab192340d0c0f4d89e6662c4718 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marek=20Ol=C5=A1=C3=A1k?= <marek.olsak@amd.com>
Date: Thu, 6 Apr 2023 23:50:29 -0400
Subject: [PATCH] si-report.py: fix printing shaders with improvements
It only printed shaders that also had regressions.
---
si-report.py | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/si-report.py b/si-report.py
index 2bf8049..bbc25c9 100755
--- a/si-report.py
+++ b/si-report.py
@@ -294,14 +294,10 @@ def subtract_stats(x, y):
result.__dict__[name] = x.__dict__[name] - y.__dict__[name]
return result
-def is_regression(before, after):
+def is_different(before, after):
for field in before.get_metrics():
- if field == 'maxwaves':
- if before.__dict__[field] > after.__dict__[field]:
- return True
- else:
- if before.__dict__[field] < after.__dict__[field]:
- return True
+ if before.__dict__[field] != after.__dict__[field]:
+ return True
return False
def divide_stats(num, div):
@@ -617,7 +613,7 @@ def print_tables(before_all_results, after_all_results):
# we don't have to add all shaders, just those that we may need
# to display
- if (is_regression(before, after) or
+ if (is_different(before, after) or
after.scratch_size > 0 or
after.spilled_vgprs > 0 or
after.privmem_vgprs > 0 or
--
GitLab