Commit e2c0ebdd authored by Matt Turner's avatar Matt Turner

egl_khr_create_context: Verify that the invalid attributes are rejected for GLES

v2: Fixed EGL_OPENGL_BIT -> EGL_OPENGL_ES_BIT typo which would cause the
    test to pass without actually testing an ES context.
parent 0a12a2ad
......@@ -27,6 +27,7 @@ create_context['valid attribute empty GL'] = plain_test('egl-create-context-vali
create_context['NULL valid attribute GLES'] = plain_test('egl-create-context-valid-attribute-null-gles')
create_context['NULL valid attribute GL'] = plain_test('egl-create-context-valid-attribute-null-gl')
create_context['invalid OpenGL version'] = plain_test('egl-create-context-invalid-gl-version')
create_context['invalid attribute GLES'] = plain_test('egl-create-context-invalid-attribute-gles')
create_context['invalid attribute GL'] = plain_test('egl-create-context-invalid-attribute-gl')
create_context['invalid flag GLES'] = plain_test('egl-create-context-invalid-flag-gles')
create_context['invalid flag GL'] = plain_test('egl-create-context-invalid-flag-gl')
......
......@@ -18,6 +18,7 @@ piglit_add_executable (egl-create-context-valid-attribute-empty-gl valid-attribu
piglit_add_executable (egl-create-context-valid-attribute-null-gles valid-attribute-null-gles.c common.c)
piglit_add_executable (egl-create-context-valid-attribute-null-gl valid-attribute-null-gl.c common.c)
piglit_add_executable (egl-create-context-invalid-gl-version invalid-gl-version.c common.c)
piglit_add_executable (egl-create-context-invalid-attribute-gles invalid-attribute-gles.c common.c)
piglit_add_executable (egl-create-context-invalid-attribute-gl invalid-attribute-gl.c common.c)
piglit_add_executable (egl-create-context-invalid-flag-gles invalid-flag-gles.c common.c)
piglit_add_executable (egl-create-context-invalid-flag-gl invalid-flag-gl.c common.c)
......
/* Copyright © 2012 Intel Corporation
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the next
* paragraph) shall be included in all copies or substantial portions of the
* Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
* IN THE SOFTWARE.
*/
#include "piglit-util-gl-common.h"
#include "piglit-util-egl.h"
#include "common.h"
static bool try_attribute(int attribute)
{
/* If the attribute is EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR
* or EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR, use a valid value for that
* attribute. This ensures that the attribute is rejected for the
* correct reason.
*/
const EGLint attribs[] = {
attribute,
(attribute == EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR)
? EGL_NO_RESET_NOTIFICATION_KHR :
(attribute == EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR)
? EGL_CONTEXT_OPENGL_CORE_PROFILE_BIT_KHR : 0,
EGL_NONE
};
bool pass = true;
ctx = eglCreateContext(egl_dpy, cfg, EGL_NO_CONTEXT, attribs);
if (ctx != NULL) {
fprintf(stderr,
"Created GLES context with invalid attribute "
"0x%08x, but this should have failed.\n",
attribute);
eglDestroyContext(egl_dpy, ctx);
pass = false;
}
/* The EGL_KHR_create_context spec says:
*
* "* If an attribute name or attribute value in <attrib_list> is not
* recognized (including unrecognized bits in bitmask attributes),
* then an EGL_BAD_ATTRIBUTE error is generated."
*/
piglit_expect_egl_error(EGL_BAD_ATTRIBUTE, PIGLIT_FAIL);
return pass;
}
int main(int argc, char **argv)
{
/* The EGL_KHR_create_context spec says:
*
* "The value for attribute EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR
* specifies a <profile> of the OpenGL API. This attribute is only
* meaningful for OpenGL contexts, and specifying it for other types of
* contexts, including OpenGL ES contexts, will generate an error."
*
* and
*
* "The attribute name
* EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR specifies the
* <reset notification behavior> of the rendering context. This
* attribute is only meaningful for OpenGL contexts, and specifying it
* for other types of contexts, including OpenGL ES contexts, will
* generate an error."
*/
EGLint bad_attributes[] = {
0xffff0000,
EGL_SAMPLE_BUFFERS,
EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR,
EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR
};
bool pass = true;
unsigned i;
if (!EGL_KHR_create_context_setup(EGL_OPENGL_ES_BIT)) {
fprintf(stderr, "ES 1 not available, trying ES 2.\n");
if (!EGL_KHR_create_context_setup(EGL_OPENGL_ES2_BIT)) {
fprintf(stderr, "ES 2 not available.\n");
piglit_report_result(PIGLIT_SKIP);
}
}
for (i = 0; i < ARRAY_SIZE(bad_attributes); i++) {
pass = try_attribute(bad_attributes[i]) && pass;
}
EGL_KHR_create_context_teardown();
piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
return EXIT_SUCCESS;
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment