GitLab

I'm trying to transition Piglit from using GLUT to using Waffle. This
requires killing all uses of GLUT functions, one-by-one.

This patch replaces all-but-one instance of glutPostRedisplay with a new
wrapper, piglit_post_redisplay. The sole remaining test that uses
glutPostRedisplay is windowoverlap; but that test doesn't use
piglit-framework, anyway.

Since piglit_escape_exit_key() calls piglit_post_redisplay() which is
defined in piglitutil_gl*, we must now link piglitutil_gl
into piglitglxutil to prevent link errors.
Acked-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-and-tested-by: Jordan Justen <jordan.l.justen@intel.com>
Tested-by: Paul Berry <stereotype441@gmail.com>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>

Create an image buffer with red, green, blue, white quadrants.
This code was extracted out of the piglit_rgbw_texture() function.
The piglit_rgbw_texture() function is then rewritten to use the new
piglit_rgbw_image() function.

Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>

Move the function from piglit-util-gl.c to piglit-util-gl-common.c so that
all GL API's can use it.
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>

In GLES, glReadPixels does not accept format=GL_FLOAT, but it does accept
format=GL_BYTE.

This shouldn't make any tests begin failing. If anything, this commit may
make pass some almost-passing tests because there is less precision in
probing with glReadPixels(GL_BYTE) than glReadPixels(GL_FLOAT).
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>

With the transform feedback wrapper functions removed,
piglit_require_transform_feedback() was the only function left in
piglit-transform-feedback.{c.h}.  This patch moves it to piglit-util.c
so that it won't get lonely.
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

Move piglit-util.* to piglit-util-gl-common.*
Signed-off-by: Blaž Tomažič <blaz.tomazic@gmail.com>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>

This patch splits off a new piglit-util function,
piglit_compare_images_color(), from the existing
piglit_probe_image_color() function.  The new function compares two
images in memory, so that the caller can take responsibility for
calling glReadPixels().

In addition, this patch creates a function
piglit_compute_probe_tolerance(), which detemines the correct
tolerance thresholds to use when comparing images.

These functions will be needed in order to test proper behaviour of
MSAA with different buffer formats, since the MSAA format test needs
to be able to read the rendered image using glReadPixels, make
adjustments to it in memory, and then compare the results.
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>

This patch eliminates code duplication between
piglit_probe_image_rgb() and piglit_probe_image_rgba() by implementing
them both in terms of a common function, piglit_probe_image_color().
In addition to being able to test GL_RGB and GL_RGBA,
piglit_probe_image_color() should be able to test any color buffer
format (e.g. GL_RG or GL_LUMINANCE_ALPHA).

piglit_probe_image_color() makes use of a new function,
piglit_num_components(), to determine how many components a given base
internal format contains (e.g. piglit_num_components(GL_RGBA) == 4).
This function is exposed through piglit-util.h in case it can be
useful in writing tests.
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
Acked-by: Marek Olšák <maraeo@gmail.com>

These utility functions to draw triangle would help in testing antialiasing
and depth related issues.

v2: Defined piglit_draw_triangle in terms of piglit_draw_triangle_z. Modified
    the comments
Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
Reviewed-by: Brian Paul <brianp@vmware.com>

For basic mipmapped texture testing, it's often useful to create
textures where each miplevel has a unique color.

The next commit will use this to simplify an existing test case, and
subsequent commits will introduce new tests based on this functionality.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>

Several tests were checking for the presence of GL extensions using
GLEW macros.  This patch changes the tests to use
piglit_is_extension_supported(), which provides the same functionality
in a way that is not dependent on GLEW.

v2: Follow piglit convention of including "GL_" in the string passed
to piglit_is_extension_supported().
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

Added functions are piglit_probe_rect_color_rgba_int() and
piglit_probe_rect_color_rgba_uint(). These functions are useful to probe
color data from integer buffers.
Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
Reviewed-by: Brian Paul <brianp@vmware.com>

Reviewed-by: Eric Anholt <eric@anholt.net>

This allows shader_runner tests to specify explicit left, right,
bottom, and top values rather than the default of (0, window width, 0,
window height).
Reviewed-by: Chad Versace <chad@chad-versace.us>

Add functions:
    piglit_probe_pixel_stencil
    piglit_probe_rect_stencil
Signed-off-by: Chad Versace <chad.versace@intel.com>

Remove duplicate definitions of piglit_require_extension() from
piglit-util-{gl,gles2}.c and define it just once in piglit-util.c. Do the
same for piglit_require_not_extension().
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Chad Versace <chad.versace@intel.com>

No tests successfully use rgbw and RGTC yet, since we can't render to
rgtc.  But when we go write some, this should reduce surprises.

This was caused by bead3e50

The proper macro for Windows operating systems is _WIN32 and not WIN32.
Thanks to Vinson Lee to remind me of that.

which don't print anything, but can return the probed pixel color.

Replace the two identical definitions in piglit-util-gl.c and in
piglit-util-gles2.c with a single definition in piglit-util.c.
Signed-off-by: Chad Versace <chad@chad-versace.us>

API-specific files are now named as COMMON_NAME-API.EXT, and
API-independent files are now named COMMON_NAME.EXT. For example,
	piglit-util.h
	piglit-util.c
	piglit-util-gl.c
	piglit-util-gles2.c
Signed-off-by: Chad Versace <chad.versace@intel.com>

And replace all occurences of glutExtensionSupported() in piglit-util.c.

Note: This belongs to a series that adds GLES2 support to Piglit.
Signed-off-by: Chad Versace <chad.versace@intel.com>