GitLab

Per issue 17 of the extension spec, unsized internalFormat values are
not allowed.  Change GL_RGBA to GL_RGBA8 and add some extra error
checks.

The test passes on NVIDIA now.

We might not have enough memory for a texture that large.
Use width or height = 1 instead.
Reviewed-by: José Fonseca <jfonseca@vmware.com>

The ARB_explicit_attrib_location tests layout-12.frag and layout-13.frag
were incorrect: they both used index == 2 (which is invalid) and
expected the compile to succeed.  Although the extension spec doesn't
state anything about generating an error on indices other than 0 or 1,
the GLSL 4.30 spec clarifies this as a compile error.  This matches the
behavior of the API call defined in ARB_blend_func_extended,
glBindFragDataLocationIndexed, which generates INVALID_VALUE for indices
other than 0 or 1.

This patch changes layout-13.frag to use index = 1 so it will actually
test the intended behavior.

layout-12.frag was just bogus: the comment said "Even though the
specified locations overlap [...]" but the test only had one variable.
This patch turns it into a negative test to ensure index == 2 is a
compile error.

This patch also adds layout-14.frag, a test to check that index < 0 is
also a compile error.

Generated from the following semantic patch:

@@
expression VER;
expression MSG;
@@

-	if (piglit_get_gl_version() < VER) {
-		printf(MSG);
-		piglit_report_result(PIGLIT_SKIP);
(
-		exit(1);
|
)
-	}

+   piglit_require_gl_version(VER);
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>

When a waffle functions fails, print the complete error message returned
emitted by waffle.
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>

Add support for input when using glut_waffle's GLX and
X11/EGL backends. Tested with fbo-clean-formats; I cycled through the
tests with the keyboard and then quit with the escape key.

v2:
    - Rewrite x11_event_loop() without continue, per brianp.
    - Remove spurious waffle_window_swap_buffers from x11_event_loop.
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>

A following patch adds support for X11 input to glut_waffle.
waffle-1.0.1 contains required bugfixes for that patch to work.
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>

This is in preparation for adding support for input to glut_waffle. Input
for each platform (X11, Wayland, etc) will be implemented in a separate
file. This patch moves common code needed for each platform from
glut_waffle.c into common.[ch].
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>

I created glut_waffle by forking Piglit's (now extinct) glut_egl. Much of
the code that glut_waffle inherited from glut_egl has never been used.
This patch kills it.
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>

I'm trying to transition Piglit from using GLUT to using Waffle. This
requires killing all uses of GLUT functions, one-by-one.

glutGet was only used in one test: fp-fragment-position.
Reviewed-by: Brian Paul <brianp@vmware.com>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>

V2: don't introduce bogus indentation; use real bools
Reviewed-by: Paul Berry <stereotype441@gmail.com>

fp-kil assumed that `1` was an unused texture name. This isn't
true if running with -fbo, so use glGenTextures to get a name
that's really unused.

Also fixed a bogus comment.

V2: use correct type
Reviewed-by: Paul Berry <stereotype441@gmail.com>

Reviewed-by: Chad Versace <chad.versace@linux.intel.com>

Converts most of the custom reshape funcs to set the projection
in either piglit_init or piglit_display, depending on whether
it depends on the size.

V2: dont introduce unrelated projection changes
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>

Reviewed-by: Paul Berry <stereotype441@gmail.com>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>

Reviewed-by: Chad Versace <chad.versace@linux.intel.com>

V2: split whitespace from non-whitespace changes
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>

V2: Don't break tests/general/read-front
Reviewed-by: Paul Berry <stereotype441@gmail.com>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>

This is part of the effort to make version handling more flexible for GLES.
Reviewed-by: Paul Berry <stereotype441@gmail.com>

Reviewed-by: Brian Paul <brianp@vmware.com>

Reviewed-by: Brian Paul <brianp@vmware.com>

Reviewed-by: José Fonseca <jfonseca@vmware.com>

Fixes egl-nok-swap-region and makes egl-nok-texture-from-pixmap not
crash (but still fails).
Reviewed-by: Paul Berry <stereotype441@gmail.com>

This test provokes a bug in Mesa as of 8/23/12 (commit 1cb07bd): when
fast depth clears are performed on multiple layers of a multilayer
depth texture (such as a 2D array or a cubemap texture), the
implementation doesn't properly track the need for depth resolves,
resulting in incorrect data when the texture is later used for
texturing.  See https://bugs.freedesktop.org/show_bug.cgi?id=50270.

Although the bug was initially discovered using cubemap textures, this
test provokes it using a 2D array texture, so that we don't have to
reason about the coordinate transformations involved in cube map
texture lookup.
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

6 bits is enough for the test to pass with the VMware svga driver.
Marek said that 5 bits allows the r300g driver to pass.
Reviewed-by: Marek Olšák <maraeo@gmail.com>

To allow building when the system's eglext.h isn't new enough.

Namely, don't print anything if the test passes, otherwise this is
interpreted as a warning, as would happen if GLES2 wasn't available;
and EGL_BAD_MATCH is generated if forward-compatible contexts aren't
supported, not EGL_BAD_ATTRIBUTE.

This reworks the test to test whether
	1) forward-compatible contexts can be created, or
	2) the correct error is generated when they can't.

Previously the test did only the first and would fail if
forward-compatible contexts couldn't be created.

v2: Fixed EGL_OPENGL_BIT -> EGL_OPENGL_ES_BIT typo which would cause the
    test to pass without actually testing an ES context.

v2: - Ask for EGL_OPENGL_BIT and skip if not available.
    - Only check EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR if GL
      3.2+
v3: - Only check EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR if GL
      3.0+
    - Skip if GL < 3.0.

v2: - Correct value of first_valid_flag.
    - Ask for EGL_OPENGL_API and skip if not available.

v2: - Update typo'd (in the spec) EGL_CONTEXT_OPENGL_* names.
    - Ask for EGL_OPENGL_BIT and skip if not available.
    - Call eglBindAPI(EGL_OPENGL_API) after _setup.
    - Fix gl_version condition (from '< 32' to '>= 32').