GitLab

This adds a policy which advises when the user should reboot the system
to avoid noisy test results due to system becoming unstable, for
instance, and therefore continues testing successfully.

To do this, a new module is proposed. A class Monitoring is used for
managing the monitoring rules. Two types of rules, MonitoringFile and
MonitoringLinuxDmesg, derived from the abstract class MonitoringBase,
have been implemented. The first allow to track a pattern on standard
files or locked files. The second, derived from dmesg.LinuxDmesg, will
track a pattern on the dmesg.

The monitoring rules must be defined in piglit.conf at the section
monitored-errors. If one of the regex is found, Piglit will raise a
PiglitAbort exception, stop the test execution -terminating test thread
pool- and exit with code 3.

Then test execution resume, after rebooting the system or not, is done
like usually with command line parameter "resume".

To call it, use command line parameter: --abort-on-monitored-error

This option implies --no-concurrent

This include also a set of unit tests for this module.
Reviewed-by: Dylan Baker <dylanx.c.baker@intel.com>

Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: Dylan Baker <baker.dylan.c@gmail.com>
Signed-off-by: Vinson Lee <vlee@freedesktop.org>

CMake actually marks that we require six 1.4.0, however, I can't find
any packages anywhere for 1.4.0, and the lowest version I've seen
requested is 1.5.2.

This fixes requirements for working with six 1.5.2, and sets tox to use
1.5.2 (and a suitable version of mock). Primarily there are a few things
we're using that are not available: six.moves.getcwd, six.viewvalues,
six.python_2_unicode_compatible.
Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>
Tested-by: Brian Paul <brianp@vmware.com>

This is not feature complete for python 3.x in and of itself, but it
gets started by using six functions rather than str and unicode.
Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>
Acked-by: Jose Fonseca <jfonseca@vmware.com>

Previously a stack trace would be suppressed in all instances unless
the PIGLIT_DEBUG environment variable was truthy. This was suboptimal
for a number of reasons.

This patch removes that functionality, now only a subset of piglit
specific exceptions that are meant to be suppressed are. All other
exceptions are directly raised, stopping the runner immediately. Other
piglit specific exceptions have been extended to have custom error
messages rather than relying on the handler to add them.

v2: - remove unit tests that no longer apply

Reviewed-by: Jose Fonseca <jfonseca@vmware.com> (v1)
Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>

When an uncaught exception reaches the top level exception handler, and
PIGLIT_DEBUG is true, then the exception will be re-raised. The problem
is that currently the exception is re-raised as 'raise e', which raise
the correct exception, but does so from the wrong context, making the
back-trace completely useless. By re-raising by simply using the 'raise'
keyword causes the exception to be passed on 'as-is', making the back
trace useful for debugging.

Trivial.
Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>

The correct way to get error messages from exceptions is to use str()
or unicode() on them, not by reading the message attribute. This is even
more relevant as we look toward python 3, where exceptions don't have a
message attribute at all.
Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>

This is the basis of providing clean, unified exception handling to
piglit, this provides a set of Exception classes and a function
decorator to be used on main functions. Together these provide well
formatted error messages that differentiate between expected failures
and unexpected failures and provide clean, readable error messages.

The goal is that this will give us the ability to get clean errors when
they are expected, and the ability to hide stack traces when they're
not.

Stack traces for unexpected errors can be turned back on by setting the
PIGLIT_DEBUG environment variable
Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>