1. 04 Dec, 2014 5 commits
    • Francisco Jerez's avatar
    • Vinson Lee's avatar
      cl-api-compile-program: Initialize variable. · 358781d8
      Vinson Lee authored
      
      
      This patch silences Clang sometimes-uninitialized warnings.
      
      compile-program.c:312:6: warning: variable 'kernel' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
                      if(!piglit_cl_check_error(errNo, CL_SUCCESS)) {
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      compile-program.c:332:18: note: uninitialized use occurs here
              clReleaseKernel(kernel);
                              ^~~~~~
      compile-program.c:312:3: note: remove the 'if' if its condition is always false
                      if(!piglit_cl_check_error(errNo, CL_SUCCESS)) {
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      compile-program.c:302:5: warning: variable 'kernel' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
              if(!piglit_cl_check_error(errNo, CL_SUCCESS)) {
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      compile-program.c:332:18: note: uninitialized use occurs here
              clReleaseKernel(kernel);
                              ^~~~~~
      compile-program.c:302:2: note: remove the 'if' if its condition is always false
              if(!piglit_cl_check_error(errNo, CL_SUCCESS)) {
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      compile-program.c:114:18: note: initialize the variable 'kernel' to silence this warning
              cl_kernel kernel;
                              ^
                               = NULL
      Signed-off-by: Vinson Lee's avatarVinson Lee <vlee@freedesktop.org>
      Reviewed-by: Serge Martin's avatarEdB <edb+piglit@sigluy.net>
      Reviewed-by: Jan Vesely's avatarJan Vesely <jan.vesely@rutgers.edu>
      358781d8
    • Kenneth Graunke's avatar
      framework: Make the logger print spinners instead of test numbers. · 5c1d198f
      Kenneth Graunke authored
      
      
      Printing out test numbers frequently exceeds the 80 character limit,
      at which point the logger starts writing many copies of the progress
      bar instead of overwriting it.  It also prompts people to say things
      like "hey, test 8423 is broken!" without realizing that tests are run
      in a nondeterministic order, so the number is meaningless.
      
      The real point was to be able to see when a thread gets stuck - i.e.
      one test keeps running forever.  We can easily show this with ASCII
      progress spinners.
      
      Instead of:
      
      [16816/16822] crash: 21, fail: 82, pass: 12307, skip: 4401, warn: 5 Running Test(s): 16814 16815 16816 16817 16818 16819 16820 16821
      
      We now get the much more compact:
      
      [09984/16822] crash: 12, fail: 53, pass: 7314, skip: 2601, warn: 4 ||\-\|/-
      
      v2: Drop the : before the spinners (requested by Dylan Baker).
      Signed-off-by: Kenneth Graunke's avatarKenneth Graunke <kenneth@whitecape.org>
      Acked-by: Dylan Baker's avatarDylan Baker <baker.dylan.c@gmail.com>
      Acked-by: Matt Turner's avatarMatt Turner <mattst88@gmail.com>
      Acked-by: Jason Ekstrand's avatarJason Ekstrand <jason.ekstrand@intel.com>
      5c1d198f
    • Kenneth Graunke's avatar
      Add a very basic version of the "primgen" test. · 8eadff91
      Kenneth Graunke authored
      
      
      We already test this functionality in position.c, but I've found this
      test valuable when doing hardware enabling due to its simplicity:
      
      - No clears (since those require the pixel pipeline to work)
      - No rendering (rasterizer discard is enabled)
      - Minimal vertex shading.
      
      I retained Marek's copyright since this is largely cut and pasted from
      his tests (primgen.c and position.c).
      Signed-off-by: Kenneth Graunke's avatarKenneth Graunke <kenneth@whitecape.org>
      Reviewed-and-tested-by: Ben Widawsky's avatarBen Widawsky <ben@bwidawsk.net>
      8eadff91
    • Kenneth Graunke's avatar
      Add imulExtended/umulExtended tests with non-uniform parameters. · 1bcc29d4
      Kenneth Graunke authored
      
      
      These are identical to the existing tests, except that we add a uniform
      containing zero to the parameters, so they're forced to be ordinary
      temporaries.
      
      This exposes a regioning bug in i965's Gen8+ imulExtended handling,
      which only worked on uniform values.
      Signed-off-by: Kenneth Graunke's avatarKenneth Graunke <kenneth@whitecape.org>
      Reviewed-by: Matt Turner's avatarMatt Turner <mattst88@gmail.com>
      1bcc29d4
  2. 03 Dec, 2014 22 commits
  3. 02 Dec, 2014 3 commits
  4. 01 Dec, 2014 10 commits