GitLab

... to match naming scheme of all other hiz FBO tests.
Signed-off-by: Chad Versace <chad@chad-versace.us>

Add the following tests:
    hiz-depth-read-fbo-d24-s0
    hiz-depth-read-fbo-d24-s8
    hiz-depth-read-fbo-d24s8
    hiz-depth-read-window-stencil0
    hiz-depth-read-window-stencil1
Signed-off-by: Chad Versace <chad@chad-versace.us>

The hiz-depth-test-* tests were not really *unit* tests. They tested both
depth tests and depth reads.

Now, they probe only color buffer and not the depth buffer. They should
not not probe the depth buffer because correct operation of 1) depth
testing and depth writes (via glDraw*) and of 2) depth buffer reads (via
glRead*) are independent. It is possible for 1 to work while 2 to fail.
The tests now cover only case 1.

The distinction here is not pedantic. On Intel SandyBridge, with hiz only
partially implemented, case 1 passes and case 2 fails.
Signed-off-by: Chad Versace <chad@chad-versace.us>

Fixes these GCC warnings.
hiz-util.c: In function 'hiz_run_test_depth_stencil_test_fbo':
hiz-util.c:605: warning: assignment from incompatible pointer type
hiz-util.c:607: warning: assignment from incompatible pointer type
hiz-util.c:609: warning: assignment from incompatible pointer type
hiz-util.c:658: warning: passing argument 1 of 'hiz_probe_color_buffer'
from incompatible pointer type

Add the following tests:
    hiz-depth-stencil-test-fbo-d0-s8
    hiz-depth-stencil-test-fbo-d24-s0
    hiz-depth-stencil-test-fbo-d24-s8
    hiz-depth-stencil-test-fbo-d24s8

These tests' goal is to check for for undefined GPU behavior when stencil
read/writes are accidentally enabled in hardware when no stencil buffer is
present, and analogously for depth read/writes when no depth buffer is
present.
Signed-off-by: Chad Versace <chad@chad-versace.us>

Add the following tests:
    hiz-stencil-read-fbo-d0-s8.c
    hiz-stencil-read-fbo-d24-s8.c
    hiz-stencil-read-fbo-d24s8.c
    hiz-stencil-read-window-depth0.c
    hiz-stencil-read-window-depth1.c

These tests check that stencil reads work correctly when rendering to
various framebuffer configurations, including FBO's and window
framebuffers.
Signed-off-by: Chad Versace <chad.versace@intel.com>

Add the following tests:
    hiz-stencil-test-fbo-d0-s8
    hiz-stencil-test-fbo-d24-s8
    hiz-stencil-test-fbo-d24s8
    hiz-stencil-test-window-depth0
    hiz-stencil-test-window-depth1

These tests check that stencil test works correctly when rendering to
various framebuffer configurations, including FBO's and window
framebuffers.
Signed-off-by: Chad Versace <chad.versace@intel.com>

... by splitting it into separate probe functions for the color and depth
buffer (hiz_probe_color_buffer() and hiz_probe_depth_buffer()).  By
separating the probe functions, we can write tests that focus on just one
feature.

Also, make the probe functions more general by adding a function parameter
that specifies the expected probe values.
Signed-off-by: Chad Versace <chad.versace@intel.com>

This function will soon cease to be useful, since more complex hiz tests
will each have their own drawing routine.

The function body has been copied into hiz_run_test_depth_test_common(),
which contains the common functionality needed by
hiz_run_test_depth_test_{fbo,window}().
Signed-off-by: Chad Versace <chad.versace@intel.com>

... in order to impose naming consistency with
hiz_run_test_depth_test_window() and future test functions.
Signed-off-by: Chad Versace <chad.versace@intel.com>

... into hiz_run_test_depth_test_window().

The immediate result of this refactoring results in a net increas in code.
But, it will prevent much code duplication on a subsequent commit that
refactors the probe functions.
Signed-off-by: Chad Versace <chad.versace@intel.com>

The test description was inaccurate.
Signed-off-by: Chad Versace <chad.versace@intel.com>

It's only used by glean, so no need to force linking against it everywhere.

Designated initializers are not supported by MSVC.

This patch also fixes a MSVC build error. getopt.h is not available on
MSVC.

stdbool.h is not available with MSVC. piglit-util.h includes stdbool.h
and defines the equivalent types for MSVC.

Fixes Linux build.

hiz_check_fbo_depth_test() has return type bool and should have returned
true (1) on success and false (0) on failure. Instead, it returned
PIGLIT_PASS (0) on success and PIGLIT_FAIL (1) on failure.

Change extension requirement from GL_ARB_fbo to GL_ARB_framebuffer_object.
Signed-off-by: Chad Versace <chad.versace@intel.com>

Add three tests, in which the FBO has the following attachments:
    1. GL_DEPTH_ATTACHMENT: GL_DEPTH_COMPONENT24
    2. GL_DEPTH_ATTACHMENT: GL_DEPTH_COMPONENT24
       GL_STENCIL_COMPONENT: GL_STENCIL_INDEX8
    3. GL_DEPTH_STENCIL_ATTACHMENT: GL_DEPTH24_STENCIL8
Reviewed-By: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Chad Versace <chad.versace@intel.com>

Add tests for two cases: when the stencil buffer is, and is not, present.
Reviewed-By: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Chad Versace <chad.versace@intel.com>

Eventually there will be over a dozen HiZ tests, so placing common
functionality in a library will reduce a good hunk of code.
Reviewed-By: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Chad Versace <chad.versace@intel.com>