Commit f387aa9a authored by Dylan Baker's avatar Dylan Baker

tests/quick: fix filtering of vs_in shader tests

This filter is incorrect as is, in that it can mask tests that it can
remove tests it shouldn't, for example
Correcting this is problematic because it changes the way the filter
works and filter will now remove different tests than it did before.

However, it is necessary for a couple of reasons. 1) it's removing tests
it shouldn't, 2) this series is going to split reverse the relationship, and this bug is going to surface there.

The good news is that while this changes the specific tests run, at least
on Intel hardware no failures are removed and no failures are added.
Tested-by: Rafael Antognolli's avatarRafael Antognolli <>
parent 31ea649a
......@@ -17,6 +17,7 @@ import random
from framework import grouptools
from framework.test import PiglitGLTest
from framework.test.shader_test import ShaderTest
from tests.all import profile as _profile
__all__ = ['profile']
......@@ -32,8 +33,8 @@ class FilterVsIn(object):
self.random = random.Random()
def __call__(self, name, _):
if 'vs_in' in name:
def __call__(self, name, test):
if isinstance(test, ShaderTest) and 'vs_in' in grouptools.split(name):
# 20%
return self.random.random() <= .2
return True
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment