Commit f2a0ebb4 authored by Anthony Pesch's avatar Anthony Pesch Committed by Juan Suárez Romero

arb_get_texture_sub_image: fix expected error when querying a level which...

arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

Change expected error from INVALID_OPERATION to INVALID_VALUE when querying a
level which hasn't been explicitly defined. The level is valid, however, the
level hasn't been explicitly defined so it should have a default width and
height of 0, making the 8x8 query produce an INVALID_VALUE.

>From the OpenGL 4.6 spec, 8.22 Texture State and Proxy State:
"Each initial texture image is null. It has zero width, height, and depth,
internal format RGBA, or R8 for buffer textures, component sizes set to zero and
component types set to NONE, the compressed flag set to FALSE, a zero compressed
size, and the bound buffer object name is zero."

>From the GetTextureSubImage errors in 8.11.4:
"An INVALID_VALUE error is generated if xoffset + width is greater than the
texture’s width, yoffset + height is greater than the texture’s height, or
zoffset + depth is greater than the texture’s depth."
Reviewed-by: default avatarArthur Huillet <ahuillet@nvidia.com>
Reviewed-by: Juan Suárez Romero's avatarJuan A. Suarez <jasuarez@igalia.com>
parent 45e115f2
......@@ -200,7 +200,7 @@ test_invalid_values(void)
8, 8, 1, /* size */
GL_RGBA, GL_FLOAT, /* bad enum */
sizeof(buffer), buffer);
if (!piglit_check_gl_error(GL_INVALID_OPERATION))
if (!piglit_check_gl_error(GL_INVALID_VALUE))
pass = false;
/* Test getting invalid offset */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment