-
Prior to JSON-ification, piglit wrote each test's results in a single call, and SyncFileWriter ensured that these were done sequentially. Now, the JSON writer internally handles locking and concurrency, so SyncFileWriter is unnecessary. Furthermore, outputting a single test's results now takes multiple write calls, so SyncFileWriter wouldn't actually guard against concurrency issues anyway. This also removes a fsync() call on each write, fixing a major performance regression on machines with non-SSDs. Prior to the JSON work, since each test mapped to a single write call, we were doing one fsync() per test case. With JSON, we started doing many more fsyncs. But none of them are actually necessary, so just scrap them all. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=39737 Cc: Chad Versace <chad@chad-versace.us> Cc: Ian Romanick <idr@freedesktop.org> Cc: Dave Airlie <airlied@gmail.com> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Chad Versace <chad@chad-versace.us> Tested-by: Ian Romanick <ian.d.romanick@intel.com>
fcaa47b2