Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
mesa
mesa
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 1,888
    • Issues 1,888
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 313
    • Merge Requests 313
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • Container Registry
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Mesa
  • mesamesa
  • Merge Requests
  • !2661

Closed
Opened Nov 08, 2019 by Eric Anholt@anholt
  • Report abuse
Report abuse

formats: Move to src/util/formats, delete main/format_unpack.py

Here it is, at last: Moving the gallium format helpers up to src/util. To demo the utility of doing so, I deleted main/format_unpack.py in favor of the src/util/format/format_pack.py-generated code.

gallium drivers are down 32k of text on x86_64. i965 is up 422k of text. vulkan drivers are effectively unchanged.

I don't like the i965 result, but I think we can get it down (move the height loop out of the individual pack/unpack functions, for example), and things will go down more as we drop the pack functions.

piglit results on skl are fine, intel-ci run still outstanding.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://gitlab.freedesktop.org/anholt/mesa.git" "ci-formats-move"
git checkout -b "anholt/mesa-ci-formats-move" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "anholt/mesa-ci-formats-move"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 1
  • Commits 12
  • Pipelines 2
  • Changes 340
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
3
Labels
gallium mesa util
Assign labels
  • View project labels
Reference: mesa/mesa!2661