[llvmpipe] piglit arb_shader_texture_lod-texgrad fails
Submitted by Vinson Lee
Assigned to mes..@..op.org
Description
mesa: 8cb9cce0 (master)
$ ./bin/arb_shader_texture_lod-texgrad -auto Left: texture2D, Right: texture2DGradARB Probe color at (77,76) Left: 0.000000 0.980392 0.015686 0.000000 Right: 0.000000 0.949020 0.047059 0.000000 PIGLIT: {'result': 'fail' }
47d0613e is the first bad commit commit 47d0613e Author: Roland Scheidegger sroland@vmware.com Date: Sat Oct 5 03:26:47 2013 +0200
gallivm: handle explicit derivatives for cubemaps
They need some special handling. Quite complicated.
Additionally, use the same code for implicit derivatives too if no_rho_approx
and no_quad_lod is set, because it seems while generally it should be ok
to use per quad lod for implicit derivatives there's at least some test which
insists that in case of cubemaps the shared lod value MUST come from a pixel
inside the primitive (due to the derivatives becoming different if a different
larger major axis is chosen).
v2: based on Brian's feedback, clean up code a bit.
And use sign bit of major axis instead of pre-select s/t/r sign for coord
mirroring (which should be the same in the end, saves 2 ands).
Also fix two bugs with select/mirror of derivatives, the minor axes need to
use major axis sign as well (instead of major derivative axis sign), and
don't mistakenly use absolute values of major derivative and inverse major
values.
Reviewed-by: Jose Fonseca <jfonseca@vmware.com>:040000 040000 87a36fd21fb08b5f4cdba877e5c2243eee0d73ba 36fbb692f6f3af2a56e437f8afbbf027683b7072 M src bisect run success
Version: git