Commit bfe7eda0 authored by Emil Velikov's avatar Emil Velikov Committed by Emil Velikov

bin/ handle reverts prior to the branchpoint

Currently we detect when a breaking commit:
 - has landed in stable, and
 - is referenced by a untagged fix in master

Yet we did not consider the case of breaking commit:
 - prior to the branchpoint, and
 - is referenced by a untagged fix in master

Addressing the latter is extremely slow, due to the size of the lookup.

That said, we can trivially use the existing is_sha_nomination() helper
to catch reverts.

Reviewed-by: Juan Suárez Romero's avatarJuan A. Suarez <>
Signed-off-by: default avatarEmil Velikov <>
(cherry picked from commit adbdfc66)
parent 221a8e33
......@@ -71,6 +71,11 @@ is_brokenby_nomination()
is_sha_nomination "$1" "broken by"
is_sha_nomination "$1" "This reverts commit "
# Use the last branchpoint as our limit for the search
latest_branchpoint=`git merge-base origin/master HEAD`
......@@ -83,7 +88,7 @@ git log --reverse --pretty=medium --grep="cherry picked from commit" $latest_bra
sed -e 's/^[[:space:]]*(cherry picked from commit[[:space:]]*//' -e 's/)//' > already_picked
# Grep for potential candidates
git log --reverse --pretty=%H -i --grep='^CC:.*mesa-stable\|^CC:.*mesa-dev\|\<fixes\>\|\<broken by\>' $latest_branchpoint..origin/master |\
git log --reverse --pretty=%H -i --grep='^CC:.*mesa-stable\|^CC:.*mesa-dev\|\<fixes\>\|\<broken by\>\|This reverts commit' $latest_branchpoint..origin/master |\
while read sha
# Check to see whether the patch is on the ignore list.
......@@ -106,6 +111,8 @@ do
elif is_brokenby_nomination "$sha"; then
elif is_revert_nomination "$sha"; then
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment