Commit 142e51da authored by Andres Gomez's avatar Andres Gomez Committed by Juan Suárez Romero

egl: Remove the 565 pbuffer-only EGL config under X11.

The CTS finally has agreed to drop the requirement for a
565-no-depth-no-stencil config for ES 3.0. Hence we can now remove the
code to satisfy this requirement using a pbuffer-only visual with
whatever other buffers the driver happens to have given us.

This reverts commit 82607f8a,
commit 6ad31c4f and
commit dacb11a5.

  - Reference the VK-GL-CTS issue (Eric E.).

  - Don't revert
    fc21394b ("egl: Quiet warning about front buffer rendering for pixmaps/pbuffers")

References: VK-GL-CTS issue 1601.
Signed-off-by: Andres Gomez's avatarAndres Gomez <>
Acked-by: Eric Engestrom's avatarEric Engestrom <>
Acked-by: Eric Anholt's avatarEric Anholt <>
Reviewed-by: Kenneth Graunke (semi-AFK still)'s avatarKenneth Graunke <>
(cherry picked from commit 02c265be)
[Juan A. Suarez: resolve trivial conflicts]
Signed-off-by: Juan Suárez Romero's avatarJuan A. Suarez Romero <>

parent 844c5948
......@@ -753,61 +753,9 @@ dri2_x11_authenticate(_EGLDisplay *disp, uint32_t id)
return dri2_x11_do_authenticate(dri2_dpy, id);
static bool
dri2_x11_config_match_attrib(struct dri2_egl_display *dri2_dpy,
const __DRIconfig *config,
unsigned int attrib,
unsigned int value)
uint32_t config_val;
if (!dri2_dpy->core->getConfigAttrib(config, attrib, &config_val))
return false;
return config_val == value;
* See if the X server can export a pixmap with the given color depth.
* Glamor in xorg-server 1.20 can't export pixmaps which have a different
* color depth than the root window as a DRI image. This makes it impossible
* to expose pbuffer-only visuals with, say, 16bpp on a 24bpp X display.
static bool
x11_can_export_pixmap_with_bpp(struct dri2_egl_display *dri2_dpy, int bpp)
bool supported = false;
#ifdef HAVE_DRI3
xcb_dri3_buffer_from_pixmap_cookie_t cookie;
xcb_dri3_buffer_from_pixmap_reply_t *reply;
xcb_pixmap_t pixmap = xcb_generate_id(dri2_dpy->conn);
xcb_create_pixmap(dri2_dpy->conn, bpp, pixmap, dri2_dpy->screen->root, 1, 1);
cookie = xcb_dri3_buffer_from_pixmap(dri2_dpy->conn, pixmap);
reply = xcb_dri3_buffer_from_pixmap_reply(dri2_dpy->conn, cookie, NULL);
if (reply) {
int *fds = xcb_dri3_buffer_from_pixmap_reply_fds(dri2_dpy->conn, reply);
for (int i = 0; i < reply->nfd; i++) {
supported = true;
xcb_free_pixmap(dri2_dpy->conn, pixmap);
return supported;
static EGLBoolean
dri2_x11_add_configs_for_visuals(struct dri2_egl_display *dri2_dpy,
_EGLDisplay *disp, bool supports_preserved,
bool add_pbuffer_configs)
_EGLDisplay *disp, bool supports_preserved)
xcb_depth_iterator_t d;
xcb_visualtype_t *visuals;
......@@ -883,47 +831,6 @@ dri2_x11_add_configs_for_visuals(struct dri2_egl_display *dri2_dpy,
/* Add a 565-no-depth-no-stencil pbuffer-only config. If X11 is depth 24,
* we wouldn't have 565 available, which the CTS demands.
if (add_pbuffer_configs && x11_can_export_pixmap_with_bpp(dri2_dpy, 16)) {
for (int j = 0; dri2_dpy->driver_configs[j]; j++) {
const __DRIconfig *config = dri2_dpy->driver_configs[j];
const EGLint config_attrs[] = {
EGLint surface_type = EGL_PBUFFER_BIT;
unsigned int rgba_masks[4] = {
0x1f << 11,
0x3f << 5,
0x1f << 0,
/* Check that we've found single-sample, no depth, no stencil,
* and single-buffered.
if (!dri2_x11_config_match_attrib(dri2_dpy, config,
!dri2_x11_config_match_attrib(dri2_dpy, config,
!dri2_x11_config_match_attrib(dri2_dpy, config,
!dri2_x11_config_match_attrib(dri2_dpy, config,
if (dri2_add_config(disp, config, config_count + 1, surface_type,
config_attrs, rgba_masks)) {
if (!config_count) {
_eglLog(_EGL_WARNING, "DRI2: failed to create any config");
return EGL_FALSE;
......@@ -1388,7 +1295,7 @@ dri2_initialize_x11_swrast(_EGLDriver *drv, _EGLDisplay *disp)
if (!dri2_x11_add_configs_for_visuals(dri2_dpy, disp, true, false))
if (!dri2_x11_add_configs_for_visuals(dri2_dpy, disp, true))
goto cleanup;
/* Fill vtbl last to prevent accidentally calling virtual function during
......@@ -1486,7 +1393,7 @@ dri2_initialize_x11_dri3(_EGLDriver *drv, _EGLDisplay *disp)
dri2_set_WL_bind_wayland_display(drv, disp);
if (!dri2_x11_add_configs_for_visuals(dri2_dpy, disp, false, true))
if (!dri2_x11_add_configs_for_visuals(dri2_dpy, disp, false))
goto cleanup;
dri2_dpy->loader_dri3_ext.core = dri2_dpy->core;
......@@ -1596,7 +1503,7 @@ dri2_initialize_x11_dri2(_EGLDriver *drv, _EGLDisplay *disp)
dri2_set_WL_bind_wayland_display(drv, disp);
if (!dri2_x11_add_configs_for_visuals(dri2_dpy, disp, true, false))
if (!dri2_x11_add_configs_for_visuals(dri2_dpy, disp, true))
goto cleanup;
/* Fill vtbl last to prevent accidentally calling virtual function during
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment