Skip to content

GitLab

mesa
mesa

freedreno: Disable PIPE_CAP_PREFER_IMM_ARRAYS_AS_CONSTBUF. 

We now have NIR opt_large_constants support in place, so we can flip the
switch and get better optimization before lowering to a constant buffer,
but also avoid having constant data mixed in with the shader's uniforms,
which should lower CPU overhead on affected shaders.

Only a few shaders are affected (<.01% impact across shader-db), but for
those the impact is pretty big:

instructions in affected programs: 748 -> 639 (-14.57%)
nops in affected programs: 364 -> 284 (-21.98%)
non-nops in affected programs: 384 -> 355 (-7.55%)
mov in affected programs: 47 -> 27 (-42.55%)
cov in affected programs: 9 -> 6 (-33.33%)
dwords in affected programs: 932 -> 836 (-10.30%)
full in affected programs: 13 -> 14 (7.69%)
constlen in affected programs: 140 -> 64 (-54.29%)
(ss) in affected programs: 14 -> 15 (7.14%)

Part-of: <!5810>
81 jobs for !5810 with fd-largeconsts in 17 minutes and 10 seconds (queued for 12 seconds)
detached
1beb4779
1 related merge request: !5810 freedreno/turnip: Use nir_opt_large_constants
Status Job ID Name Coverage
  Container
passed #5640121
aarch64
arm_build

00:00:19

passed #5640123
arm_test-base

00:00:13

passed #5640125
git_archive

00:00:15

passed #5640116
x86_build-base

00:00:12

passed #5640120
x86_build_old

00:00:11

passed #5640118
x86_test-base

00:00:12

 
  Container 2
passed #5640139
android_build

00:00:16

passed #5640144
arm64_test

00:00:21

passed #5640134
i386_build

00:00:22

passed #5640127
kernel+rootfs_amd64

00:00:36

passed #5640128
aarch64
kernel+rootfs_arm64

00:00:42

passed #5640130
aarch64
kernel+rootfs_armhf

00:00:22

passed #5640136
ppc64el_build

00:00:14

passed #5640138
s390x_build

00:00:23

passed #5640133
x86_build

00:00:12

passed #5640141
x86_test-gl

00:00:23

passed #5640143
x86_test-vk

00:00:17

 
  Sanity
passed #5640146
check mr

00:00:08

 
  Meson X86 64
passed #5640157
meson-clang

00:04:25

passed #5640155
meson-classic

00:02:00

passed #5640159
meson-clover

00:03:12

passed #5640150
meson-clover-testing

00:02:18

passed #5640151
meson-gallium

00:01:37

passed #5640153
meson-release

00:02:35

passed #5640148
meson-testing

00:02:50

passed #5640160
meson-vulkan

00:02:18

 
  Scons
passed #5640162
scons-win64

00:04:17

 
  Meson Misc
passed #5640164
meson-android

00:01:09

passed #5640169
aarch64
meson-arm64

00:01:21

passed #5640171
aarch64
meson-arm64-build-test

00:05:27

passed #5640166
aarch64
meson-armhf

00:03:25

passed #5640174
meson-i386

00:02:33

passed #5640181
meson-mingw32-x86_64

00:01:20

passed #5640178
kvm
meson-ppc64el

00:03:40

passed #5640176
kvm
meson-s390x

00:04:13

 
  Llvmpipe
passed #5640189
llvmpipe-gles2

00:02:26

passed #5640191
llvmpipe-traces

00:03:30

passed #5640183
piglit-cl

00:02:50

passed #5640186
piglit-glslparser

00:04:04

passed #5640184
piglit-quick_gl

00:06:17

passed #5640188
piglit-quick_shader

00:05:51

 
  Softpipe
passed #5640196
softpipe-gl

00:01:01

passed #5640192
softpipe-gles2

00:01:46

passed #5640193
softpipe-gles3

00:06:35

passed #5640194
softpipe-gles31 1/2

00:05:37

passed #5640195
softpipe-gles31 2/2

00:05:58

 
  Freedreno
passed #5640206
google-freedreno-db410c
arm64_a306_gles2

00:06:21

passed #5640207
google-freedreno-db410c
arm64_a306_gles3

00:06:43

passed #5640208
google-freedreno-db410c
arm64_a306_gles3_options

00:04:10

passed #5640209
google-freedreno-db820c
arm64_a530_gles2 1/2

00:07:42

passed #5640210
google-freedreno-db820c
arm64_a530_gles2 2/2

00:07:28

passed #5640211
google-freedreno-db820c
arm64_a530_gles3

00:03:57

passed #5640212
google-freedreno-db820c
arm64_a530_gles31

00:06:25

passed #5640201
google-freedreno-cheza
arm64_a630_gl

00:00:52

passed #5640197
google-freedreno-cheza
arm64_a630_gles2

00:02:03

passed #5640199
google-freedreno-cheza
arm64_a630_gles3

00:07:08

passed #5640198
google-freedreno-cheza
arm64_a630_gles31

00:05:19

passed #5640202
google-freedreno-cheza
arm64_a630_gles_others

00:04:05

passed #5640200
google-freedreno-cheza
arm64_a630_traces

00:05:28

passed #5640203
google-freedreno-cheza
arm64_a630_vk 1/2

00:07:31

passed #5640204
google-freedreno-cheza
arm64_a630_vk 2/2

00:08:49

passed #5640205
google-freedreno-cheza
arm64_a630_vk_sysmem

00:02:38

 
  Panfrost
passed #5640218
mesa-ci-aarch64-lava-collabora
panfrost-g52-gles2:arm64

00:04:30

passed #5640213
mesa-ci-aarch64-lava-collabora
panfrost-t720-gles2:arm64

00:07:44

passed #5640214
mesa-ci-aarch64-lava-collabora
panfrost-t860-gles2:arm64

00:03:26

passed #5640215
mesa-ci-aarch64-lava-collabora
panfrost-t860-gles3:arm64 1/2

00:05:33

passed #5640216
mesa-ci-aarch64-lava-collabora
panfrost-t860-gles3:arm64 2/2

00:05:49

passed #5640217
mesa-ci-aarch64-lava-collabora
panfrost-t860-traces:arm64

00:05:50

 
  Radv
passed #5640219
radv-fossils

00:08:26

 
  Virgl
passed #5640229
virgl-gl30-on-gl

00:00:32

passed #5640231
virgl-gl31-on-gl

00:01:10

passed #5640233
virgl-gl32-on-gl

00:01:28

passed #5640221
virgl-gles2-on-gl

00:02:11

passed #5640225
virgl-gles31-on-gl 1/2

00:03:44

passed #5640227
virgl-gles31-on-gl 2/2

00:04:52

passed #5640223
virgl-gles3-on-gl

00:05:22

passed #5640235
virgl-traces

00:00:49

 
  Radeonsi
passed #5640237
mesa-ci-aarch64-lava-collabora
radeonsi-stoney-gles2:amd64

00:06:17

passed #5640241
mesa-ci-aarch64-lava-collabora
radeonsi-stoney-gles31:amd64

00:08:28

passed #5640239
mesa-ci-aarch64-lava-collabora
radeonsi-stoney-gles3:amd64

00:08:17

passed #5640243
mesa-ci-aarch64-lava-collabora
radeonsi-stoney-traces:amd64

00:13:42